linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Yannick Brosseau <scientist@fb.com>
To: <acme@kernel.org>, <linux-kernel@vger.kernel.org>, <kernel-team@fb.com>
Cc: <zhu.wen-jie@hp.com>, <ak@linux.intel.com>,
	Yannick Brosseau <scientist@fb.com>
Subject: [PATCH] perf: Correctly identify anon_hugepage when generating map
Date: Wed, 7 Oct 2015 17:31:46 -0700	[thread overview]
Message-ID: <1444264306-3057-1-git-send-email-scientist@fb.com> (raw)

When parsing /proc/xxx/maps, the sscanf in perf_event__synthesize_mmap_events
truncate the map name at the space in "/anon_hugepage (deleted)".
is_anon_memory then only receive the string "/anon_hugepage" and do not detect it.
We change is_anon_memory to only compare the first part of the string
effectively ignoring if the (deleted) part is there or not.

Signed-off-by: Yannick Brosseau <scientist@fb.com>
---
 tools/perf/util/map.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/perf/util/map.c b/tools/perf/util/map.c
index b1c475d..9f7face 100644
--- a/tools/perf/util/map.c
+++ b/tools/perf/util/map.c
@@ -26,8 +26,8 @@ const char *map_type__name[MAP__NR_TYPES] = {
 static inline int is_anon_memory(const char *filename)
 {
 	return !strcmp(filename, "//anon") ||
-	       !strcmp(filename, "/dev/zero (deleted)") ||
-	       !strcmp(filename, "/anon_hugepage (deleted)");
+	       !strncmp(filename, "/dev/zero", sizeof("/dev/zero")) ||
+	       !strncmp(filename, "/anon_hugepage", sizeof("/anon_hugepage"));
 }
 
 static inline int is_no_dso_memory(const char *filename)
-- 
2.6.0


             reply	other threads:[~2015-10-08  0:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-08  0:31 Yannick Brosseau [this message]
2015-10-13 14:54 ` [PATCH] perf: Correctly identify anon_hugepage when generating map Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1444264306-3057-1-git-send-email-scientist@fb.com \
    --to=scientist@fb.com \
    --cc=acme@kernel.org \
    --cc=ak@linux.intel.com \
    --cc=kernel-team@fb.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=zhu.wen-jie@hp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).