From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752022AbbJHDhy (ORCPT ); Wed, 7 Oct 2015 23:37:54 -0400 Received: from rtits2.realtek.com ([60.250.210.242]:48784 "EHLO rtits2.realtek.com.tw" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751157AbbJHDhx (ORCPT ); Wed, 7 Oct 2015 23:37:53 -0400 Authenticated-By: X-SpamFilter-By: BOX Solutions SpamTrap 5.54 with qID t983bXV7008780, This message is accepted by code: ctloc85258 From: Roger Tseng To: Ben Hutchings CC: Maxim Levitsky , LKML , Lee Jones Subject: Re: [PATCH RESEND] rtsx_usb_ms: Use msleep_interruptible() in polling loop Thread-Topic: [PATCH RESEND] rtsx_usb_ms: Use msleep_interruptible() in polling loop Thread-Index: AQHQ+YV1Z+d3ehE3vEuJnXHGrSILfp5gfCwA Date: Thu, 8 Oct 2015 03:37:22 +0000 Message-ID: <1444275452.27426.3.camel@debian-rtk5880> References: <1443400461.2517.22.camel@decadent.org.uk> In-Reply-To: <1443400461.2517.22.camel@decadent.org.uk> Accept-Language: en-US, zh-TW Content-Language: zh-TW X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.21.81.121] Content-Type: text/plain; charset="utf-8" Content-ID: <3DA9C08E09F2CC4DBD377E968D035537@realtek.com> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id t983caGA027027 On Mon, 2015-09-28 at 01:34 +0100, Ben Hutchings wrote: > rtsx_usb_ms creates a task that mostly sleeps, but tasks in > uninterruptible sleep still contribute to the load average (for > bug-compatibility with Unix). A load average of ~1 on a system that > should be idle is somewhat alarming. > > Change the sleep to be interruptible, but still ignore signals. > > A better fix might be to replace this loop with a delayed work item. The change should be OK providing it does the same delay. You can add my ack. > References: https://bugs.debian.org/765717 > Signed-off-by: Ben Hutchings > --- > --- a/drivers/memstick/host/rtsx_usb_ms.c > +++ b/drivers/memstick/host/rtsx_usb_ms.c > @@ -706,7 +706,8 @@ poll_again: > if (host->eject) > break; > > - msleep(1000); > + if (msleep_interruptible(1000)) > + flush_signals(current); > } > > complete(&host->detect_ms_exit); -- Best regards, Roger Tseng {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I