From: yalin wang <yalin.wang2010@gmail.com>
To: broonie@kernel.org, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org
Cc: yalin wang <yalin.wang2010@gmail.com>
Subject: [RFC] regmap: change bool to 1 bit variable in struct regmap
Date: Thu, 8 Oct 2015 12:24:02 +0800 [thread overview]
Message-ID: <1444278242-27382-1-git-send-email-yalin.wang2010@gmail.com> (raw)
This patch change some bool variables in struct regmap { }
to be u8 v : 1 type, so that we can shrink the sizeof of struct regmap.
Signed-off-by: yalin wang <yalin.wang2010@gmail.com>
---
drivers/base/regmap/internal.h | 21 ++++++++++-----------
1 file changed, 10 insertions(+), 11 deletions(-)
diff --git a/drivers/base/regmap/internal.h b/drivers/base/regmap/internal.h
index 873ddf9..f4a5f7b 100644
--- a/drivers/base/regmap/internal.h
+++ b/drivers/base/regmap/internal.h
@@ -67,7 +67,6 @@ struct regmap {
void *bus_context;
const char *name;
- bool async;
spinlock_t async_lock;
wait_queue_head_t async_waitq;
struct list_head async_list;
@@ -99,7 +98,16 @@ struct regmap {
int (*reg_read)(void *context, unsigned int reg, unsigned int *val);
int (*reg_write)(void *context, unsigned int reg, unsigned int val);
- bool defer_caching;
+ u8 async : 1,
+ defer_caching : 1,
+ /* if set, remember to free reg_defaults_raw */
+ cache_free : 1,
+ /* if set, the HW registers are known to match map->reg_defaults */
+ no_sync_defaults : 1,
+ /* if set, converts bulk rw to single rw */
+ use_single_rw : 1,
+ /* if set, the device supports multi write mode */
+ can_multi_write : 1;
u8 read_flag_mask;
u8 write_flag_mask;
@@ -125,25 +133,16 @@ struct regmap {
u32 cache_only;
/* if set, only the HW is modified not the cache */
u32 cache_bypass;
- /* if set, remember to free reg_defaults_raw */
- bool cache_free;
struct reg_default *reg_defaults;
const void *reg_defaults_raw;
void *cache;
/* if set, the cache contains newer data than the HW */
u32 cache_dirty;
- /* if set, the HW registers are known to match map->reg_defaults */
- bool no_sync_defaults;
struct reg_sequence *patch;
int patch_regs;
- /* if set, converts bulk rw to single rw */
- bool use_single_rw;
- /* if set, the device supports multi write mode */
- bool can_multi_write;
-
struct rb_root range_tree;
void *selector_work_buf; /* Scratch buffer used for selector */
};
--
1.9.1
next reply other threads:[~2015-10-08 4:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-08 4:24 yalin wang [this message]
2015-10-08 8:15 ` [RFC] regmap: change bool to 1 bit variable in struct regmap Mark Brown
2015-10-08 8:23 ` yalin wang
[not found] ` <31A5ED34-0EE0-43A3-8F01-E7A5FE28CAA3@gmail.com>
2015-10-08 10:31 ` Mark Brown
2015-10-08 15:49 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1444278242-27382-1-git-send-email-yalin.wang2010@gmail.com \
--to=yalin.wang2010@gmail.com \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).