From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752515AbbJJQ73 (ORCPT ); Sat, 10 Oct 2015 12:59:29 -0400 Received: from mail-wi0-f170.google.com ([209.85.212.170]:36156 "EHLO mail-wi0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752231AbbJJQ7X (ORCPT ); Sat, 10 Oct 2015 12:59:23 -0400 From: Punit Vara To: Larry.Finger@lwfinger.net Cc: florian.c.schilhabel@googlemail.com, gregkh@linuxfoundation.org, stillcompiling@gmail.com, sudipm.mukherjee@gmail.com, dan.carpenter@oracle.com, dogukan.ergun@gmail.com, Julia.Lawall@lip6.fr, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Punit Vara Subject: [PATCH 1/4] Staging: rtl8712: Fix warning prefer eth_broadcast_addr() over memset() Date: Sat, 10 Oct 2015 22:28:39 +0530 Message-Id: <1444496322-3648-2-git-send-email-punitvara@gmail.com> X-Mailer: git-send-email 2.5.3 In-Reply-To: <1444496322-3648-1-git-send-email-punitvara@gmail.com> References: <1444496322-3648-1-git-send-email-punitvara@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch is to the rtl871x_ioctl_linux.c that fixes up following warning by checkpatch.pl: -Prefer eth_broadcast_addr() over memset() Signed-off-by: Punit Vara --- drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c index 143be0f..2ba055d 100644 --- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c +++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c @@ -1811,8 +1811,7 @@ static int r871x_wx_set_enc_ext(struct net_device *dev, if (param == NULL) return -ENOMEM; param->cmd = IEEE_CMD_SET_ENCRYPTION; - memset(param->sta_addr, 0xff, ETH_ALEN); - + eth_broadcast_addr(param->sta_addr); strncpy((char *)param->u.crypt.alg, alg_name, IEEE_CRYPT_ALG_NAME_LEN); if (pext->ext_flags & IW_ENCODE_EXT_GROUP_KEY) param->u.crypt.set_tx = 0; -- 2.5.3