From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752543AbbJJQ7j (ORCPT ); Sat, 10 Oct 2015 12:59:39 -0400 Received: from mail-wi0-f174.google.com ([209.85.212.174]:35085 "EHLO mail-wi0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752231AbbJJQ7c (ORCPT ); Sat, 10 Oct 2015 12:59:32 -0400 From: Punit Vara To: Larry.Finger@lwfinger.net Cc: florian.c.schilhabel@googlemail.com, gregkh@linuxfoundation.org, stillcompiling@gmail.com, sudipm.mukherjee@gmail.com, dan.carpenter@oracle.com, dogukan.ergun@gmail.com, Julia.Lawall@lip6.fr, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Punit Vara Subject: [PATCH 2/4] Staging: rtl8712: Use ether_addr_equal() over memcmp() Date: Sat, 10 Oct 2015 22:28:40 +0530 Message-Id: <1444496322-3648-3-git-send-email-punitvara@gmail.com> X-Mailer: git-send-email 2.5.3 In-Reply-To: <1444496322-3648-1-git-send-email-punitvara@gmail.com> References: <1444496322-3648-1-git-send-email-punitvara@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch is to the rtl871x_ioctl_linux.c file that fixes up following warning reported by checkpatch.pl : -Prefer ether_addr_equal() or ether_addr_equal_unaligned() over memcmp() bssid has datatype u8 and pnetwork->network.MacAddress has data type unsigned char. Signed-off-by: Punit Vara --- drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c index 2ba055d..1c9092e 100644 --- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c +++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c @@ -2007,7 +2007,7 @@ static int r871x_get_ap_info(struct net_device *dev, return -EINVAL; } netdev_info(dev, "r8712u: BSSID:%pM\n", bssid); - if (!memcmp(bssid, pnetwork->network.MacAddress, ETH_ALEN)) { + if (!ether_addr_equal(bssid, pnetwork->network)) { /* BSSID match, then check if supporting wpa/wpa2 */ pbuf = r8712_get_wpa_ie(&pnetwork->network.IEs[12], &wpa_ielen, pnetwork->network.IELength-12); -- 2.5.3