Re: [PATCH RFC V2 1/3] Input: goodix - add dt axis swapping and axis inversion support

Karsten Merker
2015-10-14T20:10:39Z

On Tue, Oct 13, 2015 at 06:58:07AM +0000, Tirdea, Irina wrote:
>
> > -----Original Message-----
> > From: linux-input-owner@vger.kernel.org [mailto:linux-input-owner@vger.kernel.org] On Behalf Of Karsten Merker
> > Sent: 09 October, 2015 20:56
> > To: Bastien Nocera; Dmitry Torokhov; Tirdea, Irina; Aleksei Mamlin; linux-input@vger.kernel.org; Ian Campbell
> > Cc: devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; Chen-Yu Tsai; Karsten Merker
> > Subject: [PATCH RFC V2 1/3] Input: goodix - add dt axis swapping and axis inversion support
> >
> > Implement support for the following device-tree properties
> > in the goodix touchscreen driver:
> >
> > - touchscreen-inverted-x: X axis is inverted (boolean)
> > - touchscreen-inverted-y: Y axis is inverted (boolean)
> > - touchscreen-swapped-x-y: X and Y axis are swapped (boolean)
> >
> > These are necessary on tablets which have a display in portrait
> > format while the touchscreen is in landscape format, such as e.g.
> > the MSI Primo 81.
[...]
> > @@ -950,6 +968,15 @@ static int goodix_ts_probe(struct i2c_client *client,
> > return 0;
> > }
> >
> > +#ifdef CONFIG_OF
> > + ts->swapped_x_y = of_property_read_bool(client->dev.of_node,
> > + "touchscreen-swapped-x-y");
> > + ts->inverted_x = of_property_read_bool(client->dev.of_node,
> > + "touchscreen-inverted-x");
> > + ts->inverted_y = of_property_read_bool(client->dev.of_node,
> > + "touchscreen-inverted-y");
> > +#endif
> > +
>
> If interrupt and reset gpio pins are declared in the DT configuration, this code will not
> be executed. To make the properties available for all configurations (with/without
> gpio pins declared), you should read the properties inside goodix_configure_dev().
>
> You could also use device_property_read_bool() instead, so that these properties can
> be used with ACPI 5.1. as well.

Hello,

many thanks for the review.

I'll address both points in a v3 of the patch.

Regards,
Karsten
--
Gem. Par. 28 Abs. 4 Bundesdatenschutzgesetz widerspreche ich der Nutzung
sowie der Weitergabe meiner personenbezogenen Daten für Zwecke der
Werbung sowie der Markt- oder Meinungsforschung.