From: Matt Fleming <matt@codeblueprint.co.uk>
To: Ingo Molnar <mingo@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>
Cc: Leif Lindholm <leif.lindholm@linaro.org>,
linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org,
Mark Salter <msalter@redhat.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Matt Fleming <matt.fleming@intel.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: [PATCH 04/11] efi/arm64: Clean up efi_get_fdt_params() interface
Date: Mon, 12 Oct 2015 14:56:07 +0100 [thread overview]
Message-ID: <1444658174-23378-5-git-send-email-matt@codeblueprint.co.uk> (raw)
In-Reply-To: <1444658174-23378-1-git-send-email-matt@codeblueprint.co.uk>
From: Leif Lindholm <leif.lindholm@linaro.org>
As we now have a common debug infrastructure between core and arm64 efi,
drop the bit of the interface passing verbose output flags around.
Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Tested-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Mark Salter <msalter@redhat.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Will Deacon <will.deacon@arm.com>
Signed-off-by: Matt Fleming <matt.fleming@intel.com>
---
arch/arm64/kernel/efi.c | 2 +-
drivers/firmware/efi/efi.c | 6 ++----
include/linux/efi.h | 2 +-
3 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/arch/arm64/kernel/efi.c b/arch/arm64/kernel/efi.c
index 612ad5ec1d2e..ab5eeb63e2ca 100644
--- a/arch/arm64/kernel/efi.c
+++ b/arch/arm64/kernel/efi.c
@@ -201,7 +201,7 @@ void __init efi_init(void)
struct efi_fdt_params params;
/* Grab UEFI information placed in FDT by stub */
- if (!efi_get_fdt_params(¶ms, efi_enabled(EFI_DBG)))
+ if (!efi_get_fdt_params(¶ms))
return;
efi_system_table = params.system_table;
diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/efi/efi.c
index f0372a022c86..a0a0469e2869 100644
--- a/drivers/firmware/efi/efi.c
+++ b/drivers/firmware/efi/efi.c
@@ -492,7 +492,6 @@ static __initdata struct {
};
struct param_info {
- int verbose;
int found;
void *params;
};
@@ -523,21 +522,20 @@ static int __init fdt_find_uefi_params(unsigned long node, const char *uname,
else
*(u64 *)dest = val;
- if (info->verbose)
+ if (efi_enabled(EFI_DBG))
pr_info(" %s: 0x%0*llx\n", dt_params[i].name,
dt_params[i].size * 2, val);
}
return 1;
}
-int __init efi_get_fdt_params(struct efi_fdt_params *params, int verbose)
+int __init efi_get_fdt_params(struct efi_fdt_params *params)
{
struct param_info info;
int ret;
pr_info("Getting EFI parameters from FDT:\n");
- info.verbose = verbose;
info.found = 0;
info.params = params;
diff --git a/include/linux/efi.h b/include/linux/efi.h
index 26ca9e2fd30e..4677d8a1bfd0 100644
--- a/include/linux/efi.h
+++ b/include/linux/efi.h
@@ -902,7 +902,7 @@ extern void efi_initialize_iomem_resources(struct resource *code_resource,
struct resource *data_resource, struct resource *bss_resource);
extern void efi_get_time(struct timespec *now);
extern void efi_reserve_boot_services(void);
-extern int efi_get_fdt_params(struct efi_fdt_params *params, int verbose);
+extern int efi_get_fdt_params(struct efi_fdt_params *params);
extern struct efi_memory_map memmap;
extern struct kobject *efi_kobj;
--
2.1.0
next prev parent reply other threads:[~2015-10-12 13:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-12 13:56 [GIT PULL 00/11] EFI changes for v4.4 Matt Fleming
2015-10-12 13:56 ` [PATCH 01/11] drivers/firmware: Make efi/esrt.c driver explicitly non-modular Matt Fleming
2015-10-12 13:56 ` [PATCH 02/11] efi/x86: Move efi=debug option parsing to core Matt Fleming
2015-10-12 13:56 ` [PATCH 03/11] arm64: Use core efi=debug instead of uefi_debug command line parameter Matt Fleming
2015-10-12 13:56 ` Matt Fleming [this message]
2015-10-12 13:56 ` [PATCH 05/11] efifb: Add support for 64-bit frame buffer addresses Matt Fleming
2015-10-12 13:56 ` [PATCH 06/11] efi: Add EFI_MEMORY_MORE_RELIABLE support to efi_md_typeattr_format() Matt Fleming
2015-10-12 13:56 ` [PATCH 07/11] efi: Add support for UEFIv2.5 Properties table Matt Fleming
2015-10-12 13:56 ` [PATCH 08/11] efi: Introduce EFI_NX_PE_DATA bit and set it from properties table Matt Fleming
2015-10-12 13:56 ` [PATCH 09/11] efi: Auto-load the efi-pstore module Matt Fleming
2015-10-12 13:56 ` [PATCH 10/11] x86/efi: Rename print_efi_memmap() to efi_print_memmap() Matt Fleming
2015-10-12 13:56 ` [PATCH 11/11] efi: Add "efi_fake_mem" boot option Matt Fleming
2015-10-14 15:02 ` [GIT PULL 00/11] EFI changes for v4.4 Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1444658174-23378-5-git-send-email-matt@codeblueprint.co.uk \
--to=matt@codeblueprint.co.uk \
--cc=ard.biesheuvel@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=hpa@zytor.com \
--cc=leif.lindholm@linaro.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.fleming@intel.com \
--cc=mingo@kernel.org \
--cc=msalter@redhat.com \
--cc=tglx@linutronix.de \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox