From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752782AbbJLP3C (ORCPT ); Mon, 12 Oct 2015 11:29:02 -0400 Received: from mail-qk0-f181.google.com ([209.85.220.181]:35145 "EHLO mail-qk0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752517AbbJLP26 (ORCPT ); Mon, 12 Oct 2015 11:28:58 -0400 Message-ID: <1444663735.3494.58.camel@gmail.com> Subject: Re: [PATCH 0/2] atm: iphase: Fix misleading indention and return -ENOMEM on error From: "Charles (Chas) Williams" <3chas3@gmail.com> To: Tillmann Heidsieck Cc: linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Date: Mon, 12 Oct 2015 11:28:55 -0400 In-Reply-To: <1444506439-10414-1-git-send-email-theidsieck@leenox.de> References: <1444506439-10414-1-git-send-email-theidsieck@leenox.de> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.11 (3.12.11-1.fc21) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2015-10-10 at 21:47 +0200, Tillmann Heidsieck wrote: > this series fixes two of them. The if(); warning would require > restructuring the code to a larger extend. Beyond this there remains a > whooping number of > 2k checkpatch.pl warnings and errors each. Those > can be grouped into ... > Generally I would not mind cleaning all this up for those who have to > make functional changes to the driver. However, I would like to know > from the maintainers if such an afford would be welcome or not. It doesn't bother me if you do this. I can review it.