* [PATCH v2 2/4] Staging: rtl8712: Use ether_addr_equal() over memcmp()
@ 2015-10-12 18:46 Punit Vara
2015-10-12 18:49 ` punit vara
0 siblings, 1 reply; 4+ messages in thread
From: Punit Vara @ 2015-10-12 18:46 UTC (permalink / raw)
To: Larry.Finger
Cc: florian.c.schilhabel, gregkh, stillcompiling, dan.carpenter,
Julia.Lawall, sudipm.mukherjee, devel, linux-kernel, Punit Vara
This patch is to the rtl871x_ioctl_linux.c file that fixes up following
warning reported by checkpatch.pl :
-Prefer ether_addr_equal() or ether_addr_equal_unaligned() over memcmp()
bssid and pnetwork->network.MacAddress both are 6 byte
array which aligned with u16
Signed-off-by: Punit Vara <punitvara@gmail.com>
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 143be0f..b19556a 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -2008,7 +2008,7 @@ static int r871x_get_ap_info(struct net_device *dev,
return -EINVAL;
}
netdev_info(dev, "r8712u: BSSID:%pM\n", bssid);
- if (!memcmp(bssid, pnetwork->network.MacAddress, ETH_ALEN)) {
+ if (ether_addr_equal(bssid, pnetwork->network.MacAddress)) {
/* BSSID match, then check if supporting wpa/wpa2 */
pbuf = r8712_get_wpa_ie(&pnetwork->network.IEs[12],
&wpa_ielen, pnetwork->network.IELength-12);
--
2.5.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v2 2/4] Staging: rtl8712: Use ether_addr_equal() over memcmp()
2015-10-12 18:46 [PATCH v2 2/4] Staging: rtl8712: Use ether_addr_equal() over memcmp() Punit Vara
@ 2015-10-12 18:49 ` punit vara
2015-10-13 3:43 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: punit vara @ 2015-10-12 18:49 UTC (permalink / raw)
To: Larry Finger
Cc: Florian Schilhabel, Greg KH, Joshua Clayton, Dan Carpenter,
Julia Lawall, Sudip Mukherjee, devel, linux-kernel, Punit Vara
On Tue, Oct 13, 2015 at 12:16 AM, Punit Vara <punitvara@gmail.com> wrote:
> This patch is to the rtl871x_ioctl_linux.c file that fixes up following
> warning reported by checkpatch.pl :
>
> -Prefer ether_addr_equal() or ether_addr_equal_unaligned() over memcmp()
>
> bssid and pnetwork->network.MacAddress both are 6 byte
> array which aligned with u16
>
> Signed-off-by: Punit Vara <punitvara@gmail.com>
> ---
> drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> index 143be0f..b19556a 100644
> --- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> +++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> @@ -2008,7 +2008,7 @@ static int r871x_get_ap_info(struct net_device *dev,
> return -EINVAL;
> }
> netdev_info(dev, "r8712u: BSSID:%pM\n", bssid);
> - if (!memcmp(bssid, pnetwork->network.MacAddress, ETH_ALEN)) {
> + if (ether_addr_equal(bssid, pnetwork->network.MacAddress)) {
> /* BSSID match, then check if supporting wpa/wpa2 */
> pbuf = r8712_get_wpa_ie(&pnetwork->network.IEs[12],
> &wpa_ielen, pnetwork->network.IELength-12);
> --
> 2.5.3
>
I have updated the patch as per feedback from various developers. As I
am sending second time subject should be patch v2 right ?
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2 2/4] Staging: rtl8712: Use ether_addr_equal() over memcmp()
2015-10-12 18:49 ` punit vara
@ 2015-10-13 3:43 ` Greg KH
0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2015-10-13 3:43 UTC (permalink / raw)
To: punit vara
Cc: Larry Finger, devel, Florian Schilhabel, Joshua Clayton,
linux-kernel, Julia Lawall, Sudip Mukherjee, Dan Carpenter
On Tue, Oct 13, 2015 at 12:19:12AM +0530, punit vara wrote:
> On Tue, Oct 13, 2015 at 12:16 AM, Punit Vara <punitvara@gmail.com> wrote:
> > This patch is to the rtl871x_ioctl_linux.c file that fixes up following
> > warning reported by checkpatch.pl :
> >
> > -Prefer ether_addr_equal() or ether_addr_equal_unaligned() over memcmp()
> >
> > bssid and pnetwork->network.MacAddress both are 6 byte
> > array which aligned with u16
> >
> > Signed-off-by: Punit Vara <punitvara@gmail.com>
> > ---
> > drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> > index 143be0f..b19556a 100644
> > --- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> > +++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> > @@ -2008,7 +2008,7 @@ static int r871x_get_ap_info(struct net_device *dev,
> > return -EINVAL;
> > }
> > netdev_info(dev, "r8712u: BSSID:%pM\n", bssid);
> > - if (!memcmp(bssid, pnetwork->network.MacAddress, ETH_ALEN)) {
> > + if (ether_addr_equal(bssid, pnetwork->network.MacAddress)) {
> > /* BSSID match, then check if supporting wpa/wpa2 */
> > pbuf = r8712_get_wpa_ie(&pnetwork->network.IEs[12],
> > &wpa_ielen, pnetwork->network.IELength-12);
> > --
> > 2.5.3
> >
>
> I have updated the patch as per feedback from various developers. As I
> am sending second time subject should be patch v2 right ?
Please resend the whole series please.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH RESEND 0/4] Staging: rtl8712: Fix coding style warnings
@ 2015-10-14 18:25 Punit Vara
2015-10-14 18:25 ` [PATCH v2 2/4] Staging: rtl8712: Use ether_addr_equal() over memcmp() Punit Vara
0 siblings, 1 reply; 4+ messages in thread
From: Punit Vara @ 2015-10-14 18:25 UTC (permalink / raw)
To: gregkh
Cc: Larry.Finger, devel, Julia.Lawall, sudipm.mukherjee,
dan.carpenter, linux-kernel, Punit Vara
This set of patch fixes following warnings reported by checkpatch.pl:
-Prefer eth_broadcast_addr() over memset()
-Prefer ether_addr_equal() or ether_addr_equal_unaligned() over memcmp()
-Block comments use * on subsequent lines
-Block comments use a trailing */ on a separate line
-Comparisons should place the constant on the right side of the test
v2: Fixed API suggested by : Larry Finger Larry.Finger@lwfinger.net
Improved patch description suggested by Julia Julia.Lawall@lip6.fr
Punit Vara (4):
Staging: rtl8712: Fix warning prefer eth_broadcast_addr() over
memset()
Staging: rtl8712: Use ether_addr_equal() over memcmp()
Staging: rtl8712: Coding style warnings fix for block comments
Staging: rtl8712: fix warning for placing constant on the right side
of test
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 47 ++++++++++++++-------------
1 file changed, 25 insertions(+), 22 deletions(-)
--
2.5.3
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH v2 2/4] Staging: rtl8712: Use ether_addr_equal() over memcmp()
2015-10-14 18:25 [PATCH RESEND 0/4] Staging: rtl8712: Fix coding style warnings Punit Vara
@ 2015-10-14 18:25 ` Punit Vara
0 siblings, 0 replies; 4+ messages in thread
From: Punit Vara @ 2015-10-14 18:25 UTC (permalink / raw)
To: gregkh
Cc: Larry.Finger, devel, Julia.Lawall, sudipm.mukherjee,
dan.carpenter, linux-kernel, Punit Vara
This patch is to the rtl871x_ioctl_linux.c file that fixes up following
warning reported by checkpatch.pl :
-Prefer ether_addr_equal() or ether_addr_equal_unaligned() over memcmp()
bssid and pnetwork->network.MacAddress both are 6 byte
array which aligned with u16
Signed-off-by: Punit Vara <punitvara@gmail.com>
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index 143be0f..b19556a 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -2008,7 +2008,7 @@ static int r871x_get_ap_info(struct net_device *dev,
return -EINVAL;
}
netdev_info(dev, "r8712u: BSSID:%pM\n", bssid);
- if (!memcmp(bssid, pnetwork->network.MacAddress, ETH_ALEN)) {
+ if (ether_addr_equal(bssid, pnetwork->network.MacAddress)) {
/* BSSID match, then check if supporting wpa/wpa2 */
pbuf = r8712_get_wpa_ie(&pnetwork->network.IEs[12],
&wpa_ielen, pnetwork->network.IELength-12);
--
2.5.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-10-14 18:26 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-12 18:46 [PATCH v2 2/4] Staging: rtl8712: Use ether_addr_equal() over memcmp() Punit Vara
2015-10-12 18:49 ` punit vara
2015-10-13 3:43 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2015-10-14 18:25 [PATCH RESEND 0/4] Staging: rtl8712: Fix coding style warnings Punit Vara
2015-10-14 18:25 ` [PATCH v2 2/4] Staging: rtl8712: Use ether_addr_equal() over memcmp() Punit Vara
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox