From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752911AbbJMLdx (ORCPT ); Tue, 13 Oct 2015 07:33:53 -0400 Received: from mga02.intel.com ([134.134.136.20]:7357 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752350AbbJMLdu (ORCPT ); Tue, 13 Oct 2015 07:33:50 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,677,1437462000"; d="scan'208";a="791457214" From: "Koul, Vinod" To: "peter.griffin@linaro.org" CC: "linux-kernel@vger.kernel.org" , "robh+dt@kernel.org" , "devicetree@vger.kernel.org" , "lee.jones@linaro.org" , "ludovic.barre@st.com" , "maxime.coquelin@st.com" , "dmaengine@vger.kernel.org" , "patrice.chotard@st.com" , "linux-arm-kernel@lists.infradead.org" , "srinivas.kandagatla@gmail.com" Subject: Re: [PATCH v2 6/9] dmaengine: st_fdma: Add fdma suspend and resume callbacks. Thread-Topic: [PATCH v2 6/9] dmaengine: st_fdma: Add fdma suspend and resume callbacks. Thread-Index: AQHQ7Jw/YVsvYFkvf0iv++KiUK3pIZ5gDAoAgAkQtICAAAPdgA== Date: Tue, 13 Oct 2015 11:33:45 +0000 Message-ID: <1444736023.2926.5.camel@intel.com> References: <1441980871-24475-1-git-send-email-peter.griffin@linaro.org> <1441980871-24475-7-git-send-email-peter.griffin@linaro.org> <20151007112346.GC4810@vkoul-mobl.iind.intel.com> <20151013111953.GD30342@griffinp-ThinkPad-X1-Carbon-2nd> In-Reply-To: <20151013111953.GD30342@griffinp-ThinkPad-X1-Carbon-2nd> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.223.188.113] Content-Type: text/plain; charset="utf-8" Content-ID: MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id t9DBXwct025692 On Tue, 2015-10-13 at 12:19 +0100, Peter Griffin wrote: > Hi Vinod, > > On Wed, 07 Oct 2015, Vinod Koul wrote: > > > On Fri, Sep 11, 2015 at 03:14:28PM +0100, Peter Griffin wrote: > > > +#define ST_FDMA_PM (&st_fdma_pm) > > > +#else > > > +#define ST_FDMA_PM NULL > > > +#endif > > Pls use PM helpers you dont need to do this > > > Could you point me at the PM helpers you are referring to? See SET_RUNTIME_PM_OPS and friends, defined in pm.h -- ~Vinod {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I