From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964828AbbJMRf3 (ORCPT ); Tue, 13 Oct 2015 13:35:29 -0400 Received: from smtprelay0068.hostedemail.com ([216.40.44.68]:57290 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932331AbbJMRf0 (ORCPT ); Tue, 13 Oct 2015 13:35:26 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1431:1437:1515:1516:1518:1534:1542:1593:1594:1711:1730:1747:1777:1792:2198:2199:2393:2553:2559:2562:2828:3138:3139:3140:3141:3142:3353:3622:3865:3866:3867:3868:3870:3872:3874:4250:4321:5007:6261:10004:10400:10848:11232:11657:11658:11914:12043:12295:12517:12519:12555:12679:12740:13161:13184:13229:14096:14097:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: shame55_691ec5ef55245 X-Filterd-Recvd-Size: 2965 Message-ID: <1444757721.9184.32.camel@perches.com> Subject: Re: [PATCH] MAINTAINERS: fix entry of char/misc From: Joe Perches To: Sudip Mukherjee Cc: Greg Kroah-Hartman , Andrew Morton , linux-kernel@vger.kernel.org Date: Tue, 13 Oct 2015 10:35:21 -0700 In-Reply-To: <20151013171924.GB6720@sudip-pc> References: <1444730681-5778-1-git-send-email-sudipm.mukherjee@gmail.com> <1444747685.9184.21.camel@perches.com> <20151013171924.GB6720@sudip-pc> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2015-10-13 at 22:49 +0530, Sudip Mukherjee wrote: > On Tue, Oct 13, 2015 at 07:48:05AM -0700, Joe Perches wrote: > > On Tue, 2015-10-13 at 15:34 +0530, Sudip Mukherjee wrote: > > > Greg and Arnd are supporter of char and misc drivers. While using > > > getmaintainer.pl on any patch or any file in these directories their > > > names were never displayed. > > [] > > > diff --git a/MAINTAINERS b/MAINTAINERS > > [] > > > M: Greg Kroah-Hartman > > > T: git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git > > > S: Supported > > > -F: drivers/char/* > > > -F: drivers/misc/* > > > +F: drivers/char/ > > > +F: drivers/misc/ > > > F: include/linux/miscdevice.h > > > > Do Greg and Arnd really want to be supporting all > > subsystems below drivers/char like agp and xillybus? > > I don't know that. Maybe Greg and Arnd can say. > But wasn't that the intention when char/* *nd misc/* was mentioned here? No. It was specific to files that are only in the top level directories drivers/char/ and drivers/misc/ but not any files in directories below those. There should be some difference between S: uses for some of the char and misc bits. Besides, as commit 46e642614b36 shows, Greg and Arnd are self-described fools... Still, it may be sensible have 2 MAINTAINERS sections like: CHAR and MISC CORE M: Arnd Bergmann M: Greg Kroah-Hartman T: git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git S: Supported F: drivers/char/* F: drivers/misc/* F: include/linux/miscdevice.h CHAR and MISC DRIVERS M: Arnd Bergmann M: Greg Kroah-Hartman T: git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git S: Odd fixes F: drivers/char/ F: drivers/misc/ but maybe there should be some exclusions in the drivers block like: X: drivers/char/hw_random/ X: drivers/char/ipmi/ and probably some others.