From: Olaf Hering <olaf@aepfle.de>
To: kys@microsoft.com, haiyangz@microsoft.com, gregkh@linuxfoundation.org
Cc: linux-kernel@vger.kernel.org, devel@linuxdriverproject.org,
Olaf Hering <olaf@aepfle.de>
Subject: [PATCH] Drivers: hv: vss: run only on supported host versions
Date: Tue, 13 Oct 2015 18:21:51 +0000 [thread overview]
Message-ID: <1444760511-4357-1-git-send-email-olaf@aepfle.de> (raw)
The Backup integration service on WS2012 has appearently trouble to
negotiate with a guest which does not support the provided util version.
Currently the VSS driver supports only version 5/0. A WS2012 offers only
version 1/x and 3/x, and vmbus_prep_negotiate_resp correctly returns an
empty icframe_vercnt/icmsg_vercnt. But the host ignores that and
continues to send ICMSGTYPE_NEGOTIATE messages. The result are weird
errors during boot and general misbehaviour.
Check the Windows version to work around the host bug, skip hv_vss_init
on WS2012 and older.
Signed-off-by: Olaf Hering <olaf@aepfle.de>
---
drivers/hv/hv_snapshot.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/drivers/hv/hv_snapshot.c b/drivers/hv/hv_snapshot.c
index a548ae4..52f10ed 100644
--- a/drivers/hv/hv_snapshot.c
+++ b/drivers/hv/hv_snapshot.c
@@ -331,6 +331,16 @@ static void vss_on_reset(void)
int
hv_vss_init(struct hv_util_service *srv)
{
+ switch (vmbus_proto_version) {
+ case VERSION_WS2008:
+ case VERSION_WIN7:
+ case VERSION_WIN8:
+ pr_warn("Integration service 'Backup (volume snapshot)'"
+ " not supported on this host version.\n");
+ return -ENOTSUPP;
+ default:
+ break;
+ }
recv_buffer = srv->recv_buffer;
/*
next reply other threads:[~2015-10-13 18:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-13 18:21 Olaf Hering [this message]
2015-10-19 9:43 ` [PATCH] Drivers: hv: vss: run only on supported host versions Vitaly Kuznetsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1444760511-4357-1-git-send-email-olaf@aepfle.de \
--to=olaf@aepfle.de \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox