[PATCH] ARM: socfpga: dts: add fpga manager

[PATCH] ARM: socfpga: dts: add fpga manager

[atull]

From: Alan Tull <atull@opensource.altera.com>

Add FPGA manager to device tree for SoCFPGA.

Signed-off-by: Alan Tull <atull@opensource.altera.com>
---
 arch/arm/boot/dts/socfpga.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/arm/boot/dts/socfpga.dtsi b/arch/arm/boot/dts/socfpga.dtsi
index 314e589..e37ba11 100644
--- a/arch/arm/boot/dts/socfpga.dtsi
+++ b/arch/arm/boot/dts/socfpga.dtsi
@@ -834,5 +834,12 @@
 			compatible = "altr,sys-mgr", "syscon";
 			reg = <0xffd08000 0x4000>;
 		};
+
+		hps_0_fpgamgr: fpgamgr@0xff706000 {
+			compatible = "altr,socfpga-fpga-mgr";
+			reg = <0xFF706000 0x1000
+			       0xFFB90000 0x1000>;
+			interrupts = <0 175 4>;
+		};
 	};
 };
-- 
1.9.1

Re: [PATCH] ARM: socfpga: dts: add fpga manager

[Steffen Trumtrar]

Hi Alan!

On Tue, Oct 13, 2015 at 01:28:20PM -0500, atull@opensource.altera.com wrote:
> From: Alan Tull <atull@opensource.altera.com>
> 
> Add FPGA manager to device tree for SoCFPGA.
> 
> Signed-off-by: Alan Tull <atull@opensource.altera.com>
> ---
>  arch/arm/boot/dts/socfpga.dtsi | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/socfpga.dtsi b/arch/arm/boot/dts/socfpga.dtsi
> index 314e589..e37ba11 100644
> --- a/arch/arm/boot/dts/socfpga.dtsi
> +++ b/arch/arm/boot/dts/socfpga.dtsi
> @@ -834,5 +834,12 @@
>  			compatible = "altr,sys-mgr", "syscon";
>  			reg = <0xffd08000 0x4000>;
>  		};
> +
> +		hps_0_fpgamgr: fpgamgr@0xff706000 {
> +			compatible = "altr,socfpga-fpga-mgr";
> +			reg = <0xFF706000 0x1000
> +			       0xFFB90000 0x1000>;
> +			interrupts = <0 175 4>;
> +		};
>  	};
>  };

Please keep the format in line with the rest of the file:
Hexvalues are lowercase and no 0x after the "fpgamgr@".
I'd say "And please put the node in its proper position
according to its address", but I see just now, that the
dtsi is all messed up right now anyway :-(

Regards,
Steffen

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

Re: [PATCH] ARM: socfpga: dts: add fpga manager

[Moritz Fischer]

On Tue, Oct 13, 2015 at 11:28 AM,  <atull@opensource.altera.com> wrote:
> From: Alan Tull <atull@opensource.altera.com>
>
> Add FPGA manager to device tree for SoCFPGA.
>
> Signed-off-by: Alan Tull <atull@opensource.altera.com>
Reviewed-by: Moritz Fischer <moritz.fischer@ettus.com>
> ---
>  arch/arm/boot/dts/socfpga.dtsi | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm/boot/dts/socfpga.dtsi b/arch/arm/boot/dts/socfpga.dtsi
> index 314e589..e37ba11 100644
> --- a/arch/arm/boot/dts/socfpga.dtsi
> +++ b/arch/arm/boot/dts/socfpga.dtsi
> @@ -834,5 +834,12 @@
>                         compatible = "altr,sys-mgr", "syscon";
>                         reg = <0xffd08000 0x4000>;
>                 };
> +
> +               hps_0_fpgamgr: fpgamgr@0xff706000 {
> +                       compatible = "altr,socfpga-fpga-mgr";
> +                       reg = <0xFF706000 0x1000
> +                              0xFFB90000 0x1000>;
> +                       interrupts = <0 175 4>;
> +               };
>         };
>  };
> --
> 1.9.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] ARM: socfpga: dts: add fpga manager

[Dinh Nguyen]

On Tue, 13 Oct 2015, Steffen Trumtrar wrote:

> Hi Alan!
> 
> On Tue, Oct 13, 2015 at 01:28:20PM -0500, atull@opensource.altera.com wrote:
> > From: Alan Tull <atull@opensource.altera.com>
> > 
> > Add FPGA manager to device tree for SoCFPGA.
> > 
> > Signed-off-by: Alan Tull <atull@opensource.altera.com>
> > ---
> >  arch/arm/boot/dts/socfpga.dtsi | 7 +++++++
> >  1 file changed, 7 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/socfpga.dtsi b/arch/arm/boot/dts/socfpga.dtsi
> > index 314e589..e37ba11 100644
> > --- a/arch/arm/boot/dts/socfpga.dtsi
> > +++ b/arch/arm/boot/dts/socfpga.dtsi
> > @@ -834,5 +834,12 @@
> >  			compatible = "altr,sys-mgr", "syscon";
> >  			reg = <0xffd08000 0x4000>;
> >  		};
> > +
> > +		hps_0_fpgamgr: fpgamgr@0xff706000 {
> > +			compatible = "altr,socfpga-fpga-mgr";
> > +			reg = <0xFF706000 0x1000
> > +			       0xFFB90000 0x1000>;
> > +			interrupts = <0 175 4>;
> > +		};
> >  	};
> >  };
> 
> Please keep the format in line with the rest of the file:
> Hexvalues are lowercase and no 0x after the "fpgamgr@".
> I'd say "And please put the node in its proper position
> according to its address", but I see just now, that the
> dtsi is all messed up right now anyway :-(
> 

How so? Patches are welcomed!

Please fix the "fpgamgr@" and lower case the hex values. But I would prefer the
nodes to be in alphabetical order.

Also, you need to document the "altr,socfpga-fpga-mgr".

Thanks,
Dinh
> Regards,
> Steffen
> 
> -- 
> Pengutronix e.K.                           |                             |
> Industrial Linux Solutions                 | http://www.pengutronix.de/  |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
> 

BR,
Dinh

Re: [PATCH] ARM: socfpga: dts: add fpga manager

[atull]

On Tue, 13 Oct 2015, Dinh Nguyen wrote:

> On Tue, 13 Oct 2015, Steffen Trumtrar wrote:
> 
> > Hi Alan!
> > 
> > On Tue, Oct 13, 2015 at 01:28:20PM -0500, atull@opensource.altera.com wrote:
> > > From: Alan Tull <atull@opensource.altera.com>
> > > 
> > > Add FPGA manager to device tree for SoCFPGA.
> > > 
> > > Signed-off-by: Alan Tull <atull@opensource.altera.com>
> > > ---
> > >  arch/arm/boot/dts/socfpga.dtsi | 7 +++++++
> > >  1 file changed, 7 insertions(+)
> > > 
> > > diff --git a/arch/arm/boot/dts/socfpga.dtsi b/arch/arm/boot/dts/socfpga.dtsi
> > > index 314e589..e37ba11 100644
> > > --- a/arch/arm/boot/dts/socfpga.dtsi
> > > +++ b/arch/arm/boot/dts/socfpga.dtsi
> > > @@ -834,5 +834,12 @@
> > >  			compatible = "altr,sys-mgr", "syscon";
> > >  			reg = <0xffd08000 0x4000>;
> > >  		};
> > > +
> > > +		hps_0_fpgamgr: fpgamgr@0xff706000 {
> > > +			compatible = "altr,socfpga-fpga-mgr";
> > > +			reg = <0xFF706000 0x1000
> > > +			       0xFFB90000 0x1000>;
> > > +			interrupts = <0 175 4>;
> > > +		};
> > >  	};
> > >  };
> > 
> > Please keep the format in line with the rest of the file:
> > Hexvalues are lowercase and no 0x after the "fpgamgr@".
> > I'd say "And please put the node in its proper position
> > according to its address", but I see just now, that the
> > dtsi is all messed up right now anyway :-(
> > 

Hi Steffen,

Thanks for the review.  I'll fix these things you pointed out.

"all messed up" seems kind of unclear and overstated here.  From the 
context, I assume you mean that you are pointing out that the nodes
are in more or less alphatetical order and not in order of address.  Is 
that what you mean or is the dtsi really all messed up?

Alan

> 
> How so? Patches are welcomed!
> 
> Please fix the "fpgamgr@" and lower case the hex values. But I would prefer the
> nodes to be in alphabetical order.
> 
> Also, you need to document the "altr,socfpga-fpga-mgr".
> 
> Thanks,
> Dinh
> > Regards,
> > Steffen
> > 
> > -- 
> > Pengutronix e.K.                           |                             |
> > Industrial Linux Solutions                 | http://www.pengutronix.de/  |
> > Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
> > Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
> > 
> 
> BR,
> Dinh
> 

Re: [PATCH] ARM: socfpga: dts: add fpga manager

[Steffen Trumtrar]

On Tue, Oct 13, 2015 at 02:18:22PM -0500, Dinh Nguyen wrote:
> On Tue, 13 Oct 2015, Steffen Trumtrar wrote:
> 
> > Hi Alan!
> > 
> > On Tue, Oct 13, 2015 at 01:28:20PM -0500, atull@opensource.altera.com wrote:
> > > From: Alan Tull <atull@opensource.altera.com>
> > > 
> > > Add FPGA manager to device tree for SoCFPGA.
> > > 
> > > Signed-off-by: Alan Tull <atull@opensource.altera.com>
> > > ---
> > >  arch/arm/boot/dts/socfpga.dtsi | 7 +++++++
> > >  1 file changed, 7 insertions(+)
> > > 
> > > diff --git a/arch/arm/boot/dts/socfpga.dtsi b/arch/arm/boot/dts/socfpga.dtsi
> > > index 314e589..e37ba11 100644
> > > --- a/arch/arm/boot/dts/socfpga.dtsi
> > > +++ b/arch/arm/boot/dts/socfpga.dtsi
> > > @@ -834,5 +834,12 @@
> > >  			compatible = "altr,sys-mgr", "syscon";
> > >  			reg = <0xffd08000 0x4000>;
> > >  		};
> > > +
> > > +		hps_0_fpgamgr: fpgamgr@0xff706000 {
> > > +			compatible = "altr,socfpga-fpga-mgr";
> > > +			reg = <0xFF706000 0x1000
> > > +			       0xFFB90000 0x1000>;
> > > +			interrupts = <0 175 4>;
> > > +		};
> > >  	};
> > >  };
> > 
> > Please keep the format in line with the rest of the file:
> > Hexvalues are lowercase and no 0x after the "fpgamgr@".
> > I'd say "And please put the node in its proper position
> > according to its address", but I see just now, that the
> > dtsi is all messed up right now anyway :-(
> > 
> 
> How so? Patches are welcomed!

Done :-)

> 
> Please fix the "fpgamgr@" and lower case the hex values. But I would prefer the
> nodes to be in alphabetical order.
> 

Ah, that explains it, I guess. I always sorted my patches by address :-)
The thing is, now all nodes are sorted alphabetically by phandle,
the clkmgr however seems to be ordered by address.

I prefer address btw because it is a fixed hardware constant. For the
dts files sorting via phandle is again fixed via the dtsi.

Regards,
Steffen

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

Re: [PATCH] ARM: socfpga: dts: add fpga manager

[Steffen Trumtrar]

Hi!

On Tue, Oct 13, 2015 at 09:46:15PM +0200, atull wrote:
> On Tue, 13 Oct 2015, Dinh Nguyen wrote:
> 
> > On Tue, 13 Oct 2015, Steffen Trumtrar wrote:
> > 
> > > Hi Alan!
> > > 
> > > On Tue, Oct 13, 2015 at 01:28:20PM -0500, atull@opensource.altera.com wrote:
> > > > From: Alan Tull <atull@opensource.altera.com>
> > > > 
> > > > Add FPGA manager to device tree for SoCFPGA.
> > > > 
> > > > Signed-off-by: Alan Tull <atull@opensource.altera.com>
> > > > ---
> > > >  arch/arm/boot/dts/socfpga.dtsi | 7 +++++++
> > > >  1 file changed, 7 insertions(+)
> > > > 
> > > > diff --git a/arch/arm/boot/dts/socfpga.dtsi b/arch/arm/boot/dts/socfpga.dtsi
> > > > index 314e589..e37ba11 100644
> > > > --- a/arch/arm/boot/dts/socfpga.dtsi
> > > > +++ b/arch/arm/boot/dts/socfpga.dtsi
> > > > @@ -834,5 +834,12 @@
> > > >  			compatible = "altr,sys-mgr", "syscon";
> > > >  			reg = <0xffd08000 0x4000>;
> > > >  		};
> > > > +
> > > > +		hps_0_fpgamgr: fpgamgr@0xff706000 {
> > > > +			compatible = "altr,socfpga-fpga-mgr";
> > > > +			reg = <0xFF706000 0x1000
> > > > +			       0xFFB90000 0x1000>;
> > > > +			interrupts = <0 175 4>;
> > > > +		};
> > > >  	};
> > > >  };
> > > 
> > > Please keep the format in line with the rest of the file:
> > > Hexvalues are lowercase and no 0x after the "fpgamgr@".
> > > I'd say "And please put the node in its proper position
> > > according to its address", but I see just now, that the
> > > dtsi is all messed up right now anyway :-(
> > > 
> 
> "all messed up" seems kind of unclear and overstated here.  From the 
> context, I assume you mean that you are pointing out that the nodes
> are in more or less alphatetical order and not in order of address.  Is 
> that what you mean or is the dtsi really all messed up?
> 

"more or less" was the thing that bugged me.
And for the record: I didn't try to blame anyone for this. I put
many of the nodes there myself ;-)

Regards,
Steffen

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |