From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753145AbbJMV2M (ORCPT ); Tue, 13 Oct 2015 17:28:12 -0400 Received: from e28smtp07.in.ibm.com ([122.248.162.7]:43596 "EHLO e28smtp07.in.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752197AbbJMV2K (ORCPT ); Tue, 13 Oct 2015 17:28:10 -0400 X-Helo: d28dlp03.in.ibm.com X-MailFrom: honclo@linux.vnet.ibm.com X-RcptTo: linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/3] vTPM: reformat event log to be byte-aligned From: "Hon Ching(Vicky) Lo" To: Ashley Lai Cc: tpmdd-devel@lists.sourceforge.net, Peter Huewe , Ashley Lai , Mimi Zohar , Vicky Lo , linux-kernel@vger.kernel.org In-Reply-To: <561D50DA.9090605@gmail.com> References: <1444263114-15081-1-git-send-email-honclo@linux.vnet.ibm.com> <1444263114-15081-3-git-send-email-honclo@linux.vnet.ibm.com> <561D50DA.9090605@gmail.com> Content-Type: text/plain; charset="UTF-8" Date: Tue, 13 Oct 2015 17:27:57 -0400 Message-ID: <1444771677.16434.0.camel@vtpm2014.ibm.com> Mime-Version: 1.0 X-Mailer: Evolution 2.32.3 (2.32.3-34.el6) Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15101321-0025-0000-0000-00000777BFCD Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2015-10-13 at 13:43 -0500, Ashley Lai wrote: > > On 10/07/2015 07:11 PM, Hon Ching(Vicky) Lo wrote: > > The event log generated by OpenFirmware in PowerPC is 4-byte aligned. > > This patch reformats the log to be byte-aligned for the Linux client. > > > > Signed-off-by: Hon Ching(Vicky) Lo > > --- > > arch/powerpc/kernel/prom_init.c | 13 ++++++++++++- > > 1 files changed, 12 insertions(+), 1 deletions(-) > > > > diff --git a/arch/powerpc/kernel/prom_init.c b/arch/powerpc/kernel/prom_init.c > > index b9b6bb1..8a5c248 100644 > > --- a/arch/powerpc/kernel/prom_init.c > > +++ b/arch/powerpc/kernel/prom_init.c > > @@ -1417,8 +1417,9 @@ static void __init prom_instantiate_sml(void) > > { > > phandle ibmvtpm_node; > > ihandle ibmvtpm_inst; > > - u32 entry = 0, size = 0; > > + u32 entry = 0, size = 0, succ = 0; > > u64 base; > > + __be32 val; > > > > prom_debug("prom_instantiate_sml: start...\n"); > > > > @@ -1433,6 +1434,16 @@ static void __init prom_instantiate_sml(void) > > return; > > } > > > > + if (prom_getprop(ibmvtpm_node, "ibm,sml-efi-reformat-supported", > > + &val, sizeof(val)) != PROM_ERROR) { > > + if (call_prom_ret("call-method", 2, 2, &succ, > > + ADDR("reformat-sml-to-efi-alignment"), > > + ibmvtpm_inst) != 0 || succ == 0) { > > reformat-sml-to-efi-alignment is something new just added in the firmware? I don't remember seeing it before. Yes, it's new. Our new firmware version will support it. > > > > + prom_printf("Reformat SML to EFI alignment failed\n"); > > + return; > > + } > > + } > > + > > if (call_prom_ret("call-method", 2, 2, &size, > > ADDR("sml-get-handover-size"), > > ibmvtpm_inst) != 0 || size == 0) { >