From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932235AbbJNRPh (ORCPT ); Wed, 14 Oct 2015 13:15:37 -0400 Received: from smtprelay0192.hostedemail.com ([216.40.44.192]:60037 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753340AbbJNRPf (ORCPT ); Wed, 14 Oct 2015 13:15:35 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::,RULES_HIT:2:41:69:355:379:541:599:800:960:968:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1431:1437:1515:1516:1518:1535:1593:1594:1605:1606:1730:1747:1777:1792:1981:2194:2199:2393:2553:2559:2562:2828:2892:3138:3139:3140:3141:3142:3622:3865:3866:3867:3868:3870:3871:3872:3873:3874:4117:4250:4321:4605:5007:6119:6261:7514:7903:9010:10004:10848:11026:11232:11658:11914:12043:12291:12324:12346:12438:12517:12519:12555:12681:12683:12740:13019:13138:13141:13230:13231:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: pin83_87ab100ef131e X-Filterd-Recvd-Size: 6270 Message-ID: <1444842931.2718.21.camel@perches.com> Subject: Re: [PATCH 1/2] get_maintainer: add --no-foo options to --help From: Joe Perches To: Brian Norris Cc: linux-kernel@vger.kernel.org Date: Wed, 14 Oct 2015 10:15:31 -0700 In-Reply-To: <20151014171035.GA109800@google.com> References: <1440022180-71428-1-git-send-email-computersforpeace@gmail.com> <20151014171035.GA109800@google.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2015-10-14 at 10:10 -0700, Brian Norris wrote: > Ping? Should I resend? I don't have a strong opinion about this. It seems the [no] blocks make the generic options more difficult to read. If you do resend, please cc "Andrew Morton " > On Wed, Aug 19, 2015 at 03:09:39PM -0700, Brian Norris wrote: > > Many flag options are boolean and support both a positive and a negative > > invocation from the command line. Some of these are even mentioned by > > example (e.g., --nogit is mentioned as a default option), but they > > aren't explicitly mentioned in the list of options. It happens that some > > of these are pretty important, as they are default-on, and to turn them > > off, you have to know about the --no-foo version. > > > > Anyway, let's document them now. > > > > Signed-off-by: Brian Norris > > --- > > scripts/get_maintainer.pl | 48 +++++++++++++++++++++++------------------------ > > 1 file changed, 24 insertions(+), 24 deletions(-) > > > > diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl > > index 98bae869f6d0..04ae47a8a5bd 100755 > > --- a/scripts/get_maintainer.pl > > +++ b/scripts/get_maintainer.pl > > @@ -771,43 +771,43 @@ usage: $P [options] patchfile > > version: $V > > > > MAINTAINER field selection options: > > - --email => print email address(es) if any > > - --git => include recent git \*-by: signers > > - --git-all-signature-types => include signers regardless of signature type > > + --[no]email => print email address(es) if any > > + --[no]git => include recent git \*-by: signers > > + --[no]git-all-signature-types => include signers regardless of signature type > > or use only ${signature_pattern} signers (default: $email_git_all_signature_types) > > - --git-fallback => use git when no exact MAINTAINERS pattern (default: $email_git_fallback) > > - --git-chief-penguins => include ${penguin_chiefs} > > + --[no]git-fallback => use git when no exact MAINTAINERS pattern (default: $email_git_fallback) > > + --[no]git-chief-penguins => include ${penguin_chiefs} > > --git-min-signatures => number of signatures required (default: $email_git_min_signatures) > > --git-max-maintainers => maximum maintainers to add (default: $email_git_max_maintainers) > > --git-min-percent => minimum percentage of commits required (default: $email_git_min_percent) > > - --git-blame => use git blame to find modified commits for patch or file > > + --[no]git-blame => use git blame to find modified commits for patch or file > > --git-since => git history to use (default: $email_git_since) > > --hg-since => hg history to use (default: $email_hg_since) > > - --interactive => display a menu (mostly useful if used with the --git option) > > - --m => include maintainer(s) if any > > - --r => include reviewer(s) if any > > - --n => include name 'Full Name ' > > - --l => include list(s) if any > > - --s => include subscriber only list(s) if any > > - --remove-duplicates => minimize duplicate email names/addresses > > - --roles => show roles (status:subsystem, git-signer, list, etc...) > > - --rolestats => show roles and statistics (commits/total_commits, %) > > - --file-emails => add email addresses found in -f file (default: 0 (off)) > > - --scm => print SCM tree(s) if any > > - --status => print status if any > > - --subsystem => print subsystem name if any > > - --web => print website(s) if any > > + --[no]interactive => display a menu (mostly useful if used with the --git option) > > + --[no]m => include maintainer(s) if any > > + --[no]r => include reviewer(s) if any > > + --[no]n => include name 'Full Name ' > > + --[no]l => include list(s) if any > > + --[no]s => include subscriber only list(s) if any > > + --[no]remove-duplicates => minimize duplicate email names/addresses > > + --[no]roles => show roles (status:subsystem, git-signer, list, etc...) > > + --[no]rolestats => show roles and statistics (commits/total_commits, %) > > + --[no]file-emails => add email addresses found in -f file (default: 0 (off)) > > + --[no]scm => print SCM tree(s) if any > > + --[no]status => print status if any > > + --[no]subsystem => print subsystem name if any > > + --[no]web => print website(s) if any > > > > Output type options: > > --separator [, ] => separator for multiple entries on 1 line > > using --separator also sets --nomultiline if --separator is not [, ] > > - --multiline => print 1 entry per line > > + --[no]multiline => print 1 entry per line > > > > Other options: > > --pattern-depth => Number of pattern directory traversals (default: 0 (all)) > > - --keywords => scan patch for keywords (default: $keywords) > > - --sections => print all of the subsystem sections with pattern matches > > - --mailmap => use .mailmap file (default: $email_use_mailmap) > > + --[no]keywords => scan patch for keywords (default: $keywords) > > + --[no]sections => print all of the subsystem sections with pattern matches > > + --[no]mailmap => use .mailmap file (default: $email_use_mailmap) > > --version => show version > > --help => show this help information > > > > -- > > 2.5.0.276.gf5e568e > >