linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Punit Vara <punitvara@gmail.com>
To: gregkh@linuxfoundation.org
Cc: Larry.Finger@lwfinger.net, devel@driverdev.osuosl.org,
	Julia.Lawall@lip6.fr, sudipm.mukherjee@gmail.com,
	dan.carpenter@oracle.com, linux-kernel@vger.kernel.org,
	Punit Vara <punitvara@gmail.com>
Subject: [PATCH RESEND 0/4] Staging: rtl8712: Fix coding style warnings
Date: Wed, 14 Oct 2015 23:55:51 +0530	[thread overview]
Message-ID: <1444847155-11243-1-git-send-email-punitvara@gmail.com> (raw)

This set of patch fixes following warnings reported by checkpatch.pl:

-Prefer eth_broadcast_addr() over memset()
-Prefer ether_addr_equal() or ether_addr_equal_unaligned() over memcmp()
-Block comments use * on subsequent lines
-Block comments use a trailing */ on a separate line
-Comparisons should place the constant on the right side of the test

v2: Fixed API suggested by : Larry Finger  Larry.Finger@lwfinger.net
    Improved patch description suggested by Julia Julia.Lawall@lip6.fr
Punit Vara (4):
  Staging: rtl8712: Fix warning prefer eth_broadcast_addr() over
    memset()
  Staging: rtl8712: Use ether_addr_equal() over memcmp()
  Staging: rtl8712: Coding style warnings fix for block comments
  Staging: rtl8712: fix warning for placing constant on the right side
    of     test

 drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 47 ++++++++++++++-------------
 1 file changed, 25 insertions(+), 22 deletions(-)

--
2.5.3


             reply	other threads:[~2015-10-14 18:26 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-14 18:25 Punit Vara [this message]
2015-10-14 18:25 ` [PATCH RESEND 1/4] Staging: rtl8712: Fix warning prefer eth_broadcast_addr() over memset() Punit Vara
2015-10-14 18:25 ` [PATCH v2 2/4] Staging: rtl8712: Use ether_addr_equal() over memcmp() Punit Vara
2015-10-14 18:25 ` [PATCH RESEND 3/4] Staging: rtl8712: Coding style warnings fix for block comments Punit Vara
2015-10-14 18:25 ` [PATCH v2 4/4] Staging: rtl8712: fix warning for placing constant on the right side of test Punit Vara
2015-10-17  5:16   ` Greg KH
2015-10-18  6:32     ` punit vara
2015-10-18 18:54       ` Tillmann Heidsieck
2015-10-18 19:14         ` Tillmann Heidsieck
2015-10-19  2:00       ` Greg KH
2015-10-19  2:44         ` Larry Finger
2015-10-19 15:21           ` punit vara
2015-10-22 19:04             ` punit vara
2015-10-22 19:14               ` Greg KH
2015-10-22 19:22               ` Dan Carpenter
2015-10-22 20:03                 ` punit vara
2015-10-22 20:34                   ` Dan Carpenter
2015-10-24  7:11                     ` punit vara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1444847155-11243-1-git-send-email-punitvara@gmail.com \
    --to=punitvara@gmail.com \
    --cc=Julia.Lawall@lip6.fr \
    --cc=Larry.Finger@lwfinger.net \
    --cc=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sudipm.mukherjee@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).