public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Luis de Bethencourt <luisbg@osg.samsung.com>
Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] scsi: kconfig: When possible, compile drivers with COMPILE_TEST
Date: Wed, 14 Oct 2015 16:39:05 -0700	[thread overview]
Message-ID: <1444865945.2220.90.camel@HansenPartnership.com> (raw)
In-Reply-To: <561EE5B1.40402@osg.samsung.com>

On Thu, 2015-10-15 at 00:30 +0100, Luis de Bethencourt wrote:
> On 14/10/15 23:42, James Bottomley wrote:
> > On Wed, 2015-10-14 at 22:13 +0100, Luis de Bethencourt wrote:
> >> These drivers only have runtime but no build time dependencies, so they can
> >> be built for testing purposes if the Kconfig COMPILE_TEST option is enabled.
> >>
> >> This is useful to have more build coverage and make sure that drivers are
> >> not affected by changes that could cause build regressions.
> > 
> > I don't think I understand the purpose.  If the object is to build a
> > load of old ISA drivers, why not just turn on CONFIG_ISA in the test
> > build? That's how I build test SCSI on my systems.
> > 
> > James
> > 
> > 
> 
> Hi James,
> 
> The idea is that the more drivers are built with make allyesconfig, the better.
> 
> I added COMPILE_TEST to all the drivers that can be built without having ISA,
> since they depend on runtime and not in build time. I understand your point,
> which raises the question of why isn't CONFIG_ISA set to Y in make allyesconfig.
> 
> Would this be possible?

It happens today, but it depends on architecture.  An allyesconfig on
ia32 should have it set and possibly a few others.  There's no reason an
x86-64 couldn't have it set, it's just that x86-64 was the architecture
break where ISA was discontinued, so there's no real point building that
configuration.

James



  reply	other threads:[~2015-10-14 23:39 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-14 21:13 [PATCH] scsi: kconfig: When possible, compile drivers with COMPILE_TEST Luis de Bethencourt
2015-10-14 22:25 ` Randy Dunlap
2015-10-14 22:42 ` James Bottomley
2015-10-14 23:30   ` Luis de Bethencourt
2015-10-14 23:39     ` James Bottomley [this message]
2015-10-16 13:08       ` Luis de Bethencourt
2015-10-15  1:11 ` kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1444865945.2220.90.camel@HansenPartnership.com \
    --to=james.bottomley@hansenpartnership.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=luisbg@osg.samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox