From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753926AbbJPJhI (ORCPT ); Fri, 16 Oct 2015 05:37:08 -0400 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:38033 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752817AbbJPJhG (ORCPT ); Fri, 16 Oct 2015 05:37:06 -0400 Message-ID: <1444988219.3541.3.camel@pengutronix.de> Subject: Re: [PATCH v2] pwm-backlight: fix the panel power sequence From: Philipp Zabel To: YH Huang Cc: Thierry Reding , Jingoo Han , Lee Jones , Matthias Brugger , linux-pwm@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, Tomi Valkeinen , linux-mediatek@lists.infradead.org, Sascha Hauer , yingjoe.chen@mediatek.com, Jean-Christophe Plagniol-Villard , linux-arm-kernel@lists.infradead.org Date: Fri, 16 Oct 2015 11:36:59 +0200 In-Reply-To: <1444987060-48202-1-git-send-email-yh.huang@mediatek.com> References: <1444987060-48202-1-git-send-email-yh.huang@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.9-1+b1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:100:96de:80ff:fec2:9969 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Freitag, den 16.10.2015, 17:17 +0800 schrieb YH Huang: > In order to match the panel power sequence, disable the enable_gpio > in the probe function. Also, reorder the code in the power_on and > power_off function to match the timing. Could you also have a look at the "pwm-backlight: Avoid backlight flicker when probed from DT" patch? I think in case of a panel left enabled by the bootloader, your patch will disable the backlight for a short time. best regards Philipp