From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753900AbbJPSEW (ORCPT ); Fri, 16 Oct 2015 14:04:22 -0400 Received: from smtprelay0222.hostedemail.com ([216.40.44.222]:36684 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751968AbbJPSEU (ORCPT ); Fri, 16 Oct 2015 14:04:20 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 40,2.5,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::::::::::,RULES_HIT:41:355:379:541:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2194:2199:2393:2551:2553:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3870:3871:3872:3874:4250:4321:4605:5007:6119:6261:6742:7576:7903:10011:10400:10848:11026:11232:11473:11658:11914:12043:12050:12438:12517:12519:12740:13019:13069:13161:13229:13311:13357:21080:21088,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:1:0 X-HE-Tag: hat98_5f787103edf25 X-Filterd-Recvd-Size: 2585 Message-ID: <1445018654.22921.41.camel@perches.com> Subject: Re: [PATCH] net: hix5hd2_gmac: avoid integer overload warning From: Joe Perches To: Arnd Bergmann Cc: David Laight , huangdaode , "davem@davemloft.net" , "liguozhu@hisilicon.com" , "Yisen.Zhuang@huawei.com" , "netdev@vger.kernel.org" , "linuxarm@huawei.com" , "salil.mehta@huawei.com" , "kenneth-lee-2012@foxmail.com" , "xuwei5@hisilicon.com" , "lisheng011@huawei.com" , "linux-kernel@vger.kernel.org" , "lipeng321@huawei.com" Date: Fri, 16 Oct 2015 11:04:14 -0700 In-Reply-To: <9667302.4m5v3ViVSt@wuerfel> References: <1444967657-107994-1-git-send-email-huangdaode@hisilicon.com> <4752736.dePgPCNd9q@wuerfel> <063D6719AE5E284EB5DD2968C1650D6D1CBB97A6@AcuExch.aculab.com> <9667302.4m5v3ViVSt@wuerfel> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2015-10-16 at 13:28 +0200, Arnd Bergmann wrote: > On Friday 16 October 2015 11:14:44 David Laight wrote: > > From: Arnd Bergmann > > > Sent: 16 October 2015 11:01 > > > BITS_RX_EN is an 'unsigned long' constant, so the ones complement of that > > > has bits set that do not fit into a 32-bit variable on 64-bit architectures, > > > which causes a harmless gcc warning: > > ... > > > static void hix5hd2_port_disable(struct hix5hd2_priv *priv) > > > { > > > - writel_relaxed(~(BITS_RX_EN | BITS_TX_EN), priv->base + PORT_EN); > > > + writel_relaxed(~(u32)(BITS_RX_EN | BITS_TX_EN), priv->base + PORT_EN); > > > writel_relaxed(0, priv->base + DESC_WR_RD_ENA); > > > > ISTM that just means that the constants shouldn't be 'long'. > > Right, but that would probably mean changing the BIT() macro or not using it > here. In the past I've argued against using that macro, but I've given > up that fight. Fight on... (Somebody must have gone to USC here) There might be value in a BIT_U32 macro. Maybe BIT_U64 too.