From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751731AbbJPVWW (ORCPT ); Fri, 16 Oct 2015 17:22:22 -0400 Received: from smtprelay0011.hostedemail.com ([216.40.44.11]:58934 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750759AbbJPVWU (ORCPT ); Fri, 16 Oct 2015 17:22:20 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 40,2.5,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::::::::::::,RULES_HIT:41:355:379:541:599:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2194:2199:2393:2559:2562:2828:3138:3139:3140:3141:3142:3353:3622:3865:3866:3867:3870:3871:3872:3874:4250:4321:4605:5007:6119:6261:6742:7903:9036:10011:10400:10848:11026:11232:11473:11658:11914:12043:12438:12517:12519:12740:13069:13311:13357:21080:21088,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:1:0 X-HE-Tag: rifle06_4e06f9bfeb435 X-Filterd-Recvd-Size: 3327 Message-ID: <1445030535.22921.73.camel@perches.com> Subject: Re: [PATCH] net: hix5hd2_gmac: avoid integer overload warning From: Joe Perches To: Sergei Shtylyov Cc: Arnd Bergmann , David Laight , huangdaode , "davem@davemloft.net" , "liguozhu@hisilicon.com" , "Yisen.Zhuang@huawei.com" , "netdev@vger.kernel.org" , "linuxarm@huawei.com" , "salil.mehta@huawei.com" , "kenneth-lee-2012@foxmail.com" , "xuwei5@hisilicon.com" , "lisheng011@huawei.com" , "linux-kernel@vger.kernel.org" , "lipeng321@huawei.com" Date: Fri, 16 Oct 2015 14:22:15 -0700 In-Reply-To: <562146ED.1030308@cogentembedded.com> References: <1444967657-107994-1-git-send-email-huangdaode@hisilicon.com> <4752736.dePgPCNd9q@wuerfel> <063D6719AE5E284EB5DD2968C1650D6D1CBB97A6@AcuExch.aculab.com> <9667302.4m5v3ViVSt@wuerfel> <1445018654.22921.41.camel@perches.com> <562146ED.1030308@cogentembedded.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2015-10-16 at 21:50 +0300, Sergei Shtylyov wrote: > On 10/16/2015 09:04 PM, Joe Perches wrote: > > >>>> BITS_RX_EN is an 'unsigned long' constant, so the ones complement of that > >>>> has bits set that do not fit into a 32-bit variable on 64-bit architectures, > >>>> which causes a harmless gcc warning: > >>> ... > >>>> static void hix5hd2_port_disable(struct hix5hd2_priv *priv) > >>>> { > >>>> - writel_relaxed(~(BITS_RX_EN | BITS_TX_EN), priv->base + PORT_EN); > >>>> + writel_relaxed(~(u32)(BITS_RX_EN | BITS_TX_EN), priv->base + PORT_EN); > >>>> writel_relaxed(0, priv->base + DESC_WR_RD_ENA); > >>> > >>> ISTM that just means that the constants shouldn't be 'long'. > >> > >> Right, but that would probably mean changing the BIT() macro or not using it > >> here. In the past I've argued against using that macro, but I've given > >> up that fight. > > > > Fight on... (Somebody must have gone to USC here) > > > > There might be value in aefin BIT_U32 macro. > > Maybe BIT_U64 too. > > There's BIT_ULL() already. I know, but symmetry is good. I think there'd be no harm in adding it. Perhaps adding all the sized variants would be useful. Something like: #define BIT_OF_TYPE(type, nr) \ ({ \ typeof(type) rtn; \ BUILD_BUG_ON(__builtin_constant_p(nr) && \ ((nr) < 0 || \ (nr) >= sizeof(type) * BITS_PER_BYTE)); \ rtn = ((type)1) << (nr); \ rtn; \ }) #define BIT_U8(nr) BIT_OF_TYPE(u8, nr) #define BIT_U16(nr) BIT_OF_TYPE(u16, nr) #define BIT_U32(nr) BIT_OF_TYPE(u32, nr) #define BIT_U64(nr) BIT_OF_TYPE(u64, nr)