From: Michael Ellerman <mpe@ellerman.id.au>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: benh@kernel.crashing.org, paulus@samba.org,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v2] powerpc/mpc5xxx: Avoid dereferencing potentially freed memory
Date: Mon, 19 Oct 2015 15:38:10 +1100 [thread overview]
Message-ID: <1445229490.11557.3.camel@ellerman.id.au> (raw)
In-Reply-To: <562158A3.90000@wanadoo.fr>
On Fri, 2015-10-16 at 22:05 +0200, Christophe JAILLET wrote:
> Hi,
> sorry if un-clear.
>
> What I mean is that in the patch related
> 'powerpc/sysdev/mpc5xxx_clocks.c', there was no call to 'be32_to_cpup'.
> So in the proposed patch, 'of_property_read_u32' adds it.
>
> While in the patch against 'powerpc/kernel/prom.c', 'be32_to_cpup' was
> called explicitly.
> So using 'of_property_read_u32' keep the same logic.
Ah right, I understand now.
> Basically the code from 'mpc5xxx_clocks.c' and from 'prom.c' were
> written the same way. I found spurious that a call to 'be32_to_cpup' was
> done in only one case.
> Maybe, it was a missing in 'mpc5xxx_clocks.c'.
Yes it was missing in that code.
But that's not a real bug because that code only ever runs on BE systems.
cheers
next prev parent reply other threads:[~2015-10-19 4:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-11 20:27 [PATCH] powerpc/mpc5xxx: Use of_get_next_parent to simplify code Christophe JAILLET
2015-10-11 20:44 ` Julia Lawall
2015-10-12 5:05 ` Christophe JAILLET
2015-10-14 4:00 ` Michael Ellerman
2015-10-15 5:56 ` [PATCH v2] powerpc/mpc5xxx: Avoid dereferencing potentially freed memory Christophe JAILLET
2015-10-15 6:36 ` Michael Ellerman
2015-10-16 6:20 ` Christophe JAILLET
2015-10-16 7:15 ` Gabriel Paubert
2015-10-16 9:49 ` Michael Ellerman
2015-10-16 20:05 ` Christophe JAILLET
2015-10-19 4:38 ` Michael Ellerman [this message]
2015-10-15 11:11 ` powerpc/mpc5xxx: Use of_get_next_parent to simplify code Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1445229490.11557.3.camel@ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=benh@kernel.crashing.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox