From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932065AbbJSRqY (ORCPT ); Mon, 19 Oct 2015 13:46:24 -0400 Received: from mail-bn1on0138.outbound.protection.outlook.com ([157.56.110.138]:61760 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753324AbbJSRqS (ORCPT ); Mon, 19 Oct 2015 13:46:18 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=scottwood@freescale.com; Message-ID: <1445276769.5185.292.camel@freescale.com> Subject: Re: [PATCH 04/17] powerpc: mpic: use IRQCHIP_SKIP_SET_WAKE instead of redundant mpic_irq_set_wake From: Scott Wood To: Sudeep Holla CC: Benjamin Herrenschmidt , "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "Thomas Gleixner" , "Rafael J. Wysocki" , "Paul Mackerras" , Michael Ellerman , "Hongtao Jia" , Marc Zyngier , "linuxppc-dev@lists.ozlabs.org" , "Wang Dongsheng-B40534" Date: Mon, 19 Oct 2015 12:46:09 -0500 In-Reply-To: <562529EF.7050404@arm.com> References: <1442850433-5903-1-git-send-email-sudeep.holla@arm.com> <1442850433-5903-5-git-send-email-sudeep.holla@arm.com> <1442981170.19102.322.camel@freescale.com> <562529EF.7050404@arm.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.0-fta1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Originating-IP: [50.157.106.250] X-ClientProxiedBy: BN3PR15CA0001.namprd15.prod.outlook.com (25.165.72.11) To BLUPR03MB1473.namprd03.prod.outlook.com (25.163.81.158) X-Microsoft-Exchange-Diagnostics: 1;BLUPR03MB1473;2:7/Orpk8olPY5cEyyafA5TiyPc3+IIAf/kQJLV2mvIpyb5rQztDL+tKHotehcFzumGgqaVHagYLSKRuhZyFbwv/JVGQL28wYtkK+N5RRIasl6j1L07QH7Jjb+67q9pbdWkQi/o/Sd4CZFALuZ8k7d95zYKyIO2Rf76weAw0TYJFg=;3:ixahFWV+qKsRfsV2IylelnN1pthTDQujYFx29rvFGE9Id4XFsdYdtZK6b43zQyy5DvJPRjhxekCj9SfdMuNn846ldD5I64py1TYmEF6X+TN06utBvputMGERkkXH55Ol9hnxBPJ6fGLvn2MULI5fMQ==;25:mV0BEFjPTEM+5ER0j91DbFCfG5E9ElU0QmgP1Q5dc3wL/Fj0dfnrUTEpoN8p/05SP182VVZ+kM+ZfsdLNPbn5QIoc6S9KdJXYAoTzNQk0cwKU5WjkbdZjhmyh8kg7cECszKzNFAa++LYSq1/iNgSy+DuOLbOpwYc4oGstD5z2oS+oF+d5U35GwGqYtmL6wvptkRZtsn8yokY8wfM9WaNwx8ZBtCdhlWlHmBoDMyz7/Vd2x42V30vT29JNrsWV4akImsrQzczfCrWWSV0I8acNg== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR03MB1473; X-Microsoft-Exchange-Diagnostics: 1;BLUPR03MB1473;20:Ope4e4B1qnd9QxK+YYbQcrOgYWey/FESu9hFTVVIOgWvH2Ht7VALvXe3dVy8yWX5u/tNfNRlIuTZPRV5FctuMvKPkerwzmrbpUYAocOkaaDAj4ff63DO/Wa5msBXHPQrkQwoE8s67sDDxW4F/0PXdwSB7EID07qVaj4dpGMO6UGCc3cPy2g6n6oKLBA1oVvwU4V99kbOaS0nPh343jm2Qafd2QMb0gIwK1anbyHsQt6m3Vhge7x9SdQLd+gKFcCA6fOb6e+vf5NS/cxctkn9jBWNXRNmSjaQvOkbVKcrQG+wyQ4ABpvhxn1v1IaQf8T583a8v6AdfVips/JCd086YE/1+3ku3Y58dKKyPIeDrhuMyYpAjxJcAY1GyTyg99H3qkZp9DzT1DtCb4Z3XeaT9/ZJc9xKoIiIvJ4Gac7qnk20xHihHzozxP9Z8zVKX24zfZWryHHOZOKkjksOzBM59SZNNhPcz5LeVItUlRKOyo4LzawukjmzzPjqeFcxCbKx;4:u6IlYqHltHJTGz7APWZ4gT7kl5OjSVAPWhj5onCzgSxIelKkK5sUDdiC5q9Z767Whq3yOV3Rr+fdBlwN+CNagUJRcnNdZ0OwrTJYoMGpz5er5a2yb3UWoNhC7szH1Bzi1PE2+SbrRRcxnJL6/Tfwk5qDoTM1JFfLUrmpgxXnuNpQzOAMp7IJ/0pEG74z7lbEqlHOacY/qCbKpzFYp64xtgVlV2LGw32n/0tgvVX39KmA5lCrxVy5cEl53p3hYNlvv/lHVlJR00CqGkbtIbwux6eLNQu8n5GMOqgRGo5qblwOr94TXnUw/SKv5LFGQcrVRWbAhhiFAJh1XN6BnkL5ZZoQhqaeC0SBVJXFXeb4t80= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(101931422205132); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(520078)(8121501046)(3002001);SRVR:BLUPR03MB1473;BCL:0;PCL:0;RULEID:;SRVR:BLUPR03MB1473; X-Forefront-PRVS: 07349BFAD2 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6009001)(199003)(189002)(24454002)(377424004)(479174004)(105586002)(122386002)(2950100001)(81156007)(97736004)(77096005)(189998001)(5001960100002)(4001150100001)(87976001)(107886002)(110136002)(86362001)(5007970100001)(5820100001)(40100003)(50466002)(5004730100002)(23676002)(66066001)(19580405001)(19580395003)(64706001)(50226001)(106356001)(46102003)(93886004)(101416001)(103116003)(42186005)(47776003)(33646002)(76176999)(36756003)(50986999)(5008740100001)(92566002)(99106002)(4001430100001);DIR:OUT;SFP:1102;SCL:1;SRVR:BLUPR03MB1473;H:snotra.local;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTFVQUjAzTUIxNDczOzIzOjF4SVQ2NGE4dDhTcFZBN3BxeFN3RDQ0emZ5?= =?utf-8?B?Vzl3OTVuS0IzZS9wbzRpcFZ3NlR3a1ZyRzF2Z1Z5c1ptYlJmSlJ2Y0JQaVVK?= =?utf-8?B?RzFkSDliZ2QrKzZ1VVBTaHRsUVFrWURPK25ESGw4WmVzZFVobk9DRHduWFB1?= =?utf-8?B?SUhidjZRb3V6QW9uWk9kcnBTU2tVTXBoRVZ6eU5wQmFGNjNQK1phYmJPYjFK?= =?utf-8?B?eHRzZC8vcys4WmVyVVhwdERCcHpPa2ZyTDN2bUR0dXRIRmxYd1NxK1puZ1d2?= =?utf-8?B?eUVJT2VpTXR0SDNoQ2l2b29yOThNTTVFZ3Iyd3pQcklWOWVZV0dGWjlHS01o?= =?utf-8?B?dW9yKzArWEJEbGE5OUc3bWF2emd2VHJtQkpERVh5T282NGEvVTM0dTIwbDBK?= =?utf-8?B?S3hNMVdwQkNnL2FCQXNCZ253OThINDdMcjBEQStRdXBOdi9zaUo0OGd3TStM?= =?utf-8?B?dXRTbS8xZEFmZW1DOVpGcjhVVVJwTWFaa0w0cWpVZGJNd1VjSXlJeFRDSmta?= =?utf-8?B?cnlmVUdyZnlTYUg1aXg2NjdJcmVaVXRxcDNESENqbVF2bEpqc1lOUVkvNUF6?= =?utf-8?B?RXlUcDAxaUI5eTBSbWFpSlA0TWFteTIwR3A4WWk1OTlsRDBlT2xpS01aQ00y?= =?utf-8?B?SVFEeHIyVDlwaTROTHdTQkdVWFZianhKNnZyTzBleGVLZ2lVR3N4S3RQcWxJ?= =?utf-8?B?WmJyRWZEYW9NSzFRcDAwYmJWZ0NDOGRUcXM2T1FYc3BMVk45d0Job0RkRm5K?= =?utf-8?B?MDh5TXNDQ1Z4azlMczlDMFZOYWpaTmt1OWZMU2Fkckk1QjFDYjloajE4cWtK?= =?utf-8?B?QW9BOEV5Tm9oNHRscndpQzZDU1ZDZWhDRUFmQXo1VmpSUW5uaTRlOXVDUTRB?= =?utf-8?B?aWNVSFVUWnZuSmJ1TUNMazdlSWsra0JvRFpTOElZOTZLblFia2hudlhsU29m?= =?utf-8?B?d2FhdVB1REw5eTluUjZVaFhmc2tZRkpnSDUyWmZCLzdkYTF6OThQZkhmY1ZE?= =?utf-8?B?QVhDVHhob1N3RmRaSFhuRjNvN1hUS3hhbnZWa1hCUDlYWXdMK2sxalpWMUZp?= =?utf-8?B?UTBjVk9leW9tNnJCU2t5R0RNNDNrSC9ac1M5MTBYSy9ZdVU2Y2lvRjJtUjI5?= =?utf-8?B?eExST1ZHTVVIeW5zN29lbUM3UEhweGY4UTAwOEZ5OGNqaStodDh2YmJHTXFr?= =?utf-8?B?TjhhaEladk5GNFFZL25uMERBa1EwSXVsYVhBR29ZQUl0MDlzMVBPK1RWV0Vu?= =?utf-8?B?bzVTc3hzL2ZQOHk1SmlWNlJUbHJwRmlhanY3QkdBUldXTDFlZWFuZ09WRjkv?= =?utf-8?B?c2d0dVRrdWtuR0xmK2dvcXBIOTQ0ZUpBR3FWblBEZzRMZXQ3S2hyYWppU2l5?= =?utf-8?B?T3B5aG5qWkxscnlIRm1xOU9xRldGUFFaMlhCZ3BUK0xablRzK3V2RXd5NW5U?= =?utf-8?B?QTh4RVQ1OWhVM1laNlFSak9BV05kbmJRMUE5Y2NYVUdVK0tGSVdGVkUyRjky?= =?utf-8?B?czFFdWR0TGkzRmgvNHBYUWRibUZtQ1JIT1F3YXp6T2FvYXV2RnJHR1IzMFpu?= =?utf-8?B?OEJVOHJYKzE5cEVjcFVxVk9HK1FMSDJkcHRScGxHUnY3ZkhaU0NlWnlKME1j?= =?utf-8?B?a0ROUnQzaHhoMGhBK0d2N1VqRDRnSEU1YTd3Kzh4ZlZOTjgwNE5qRHZ3PT0=?= X-Microsoft-Exchange-Diagnostics: 1;BLUPR03MB1473;5:A5M03cnqPGbs0KgdLZVTK4NJzN2R/h6kV7QgC5D1uST34zyV7Z5p6AgDFOx63gl/G27Qa/DIoCs7IrgQoSXEI9DPwdfIvlZlSBzpV6cZruVVmKKMsu95n/V0yoH3pvf6Ij5Z9IQ9k9dGVkJyTbOnDQ==;24:Sbmmwk5pk4eJeFDUko37vYvb7xUge+wwdstj3Pk6Xe85RaomobUJL/lwavlVlKYmt2rHMCw1iJJSKBEeqNxk5p360Zj+Fk7HSoQ7I4TXryQ=;20:ds9C5AqQrQOZh7ZnCi+kHwiVRbKImOCu6P+XET5azu2QUdqBnH2XhqBqgUFOiqx1HyV4CK+eEQV+B1TNk7TcPQ== X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2015 17:46:15.5651 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR03MB1473 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2015-10-19 at 18:35 +0100, Sudeep Holla wrote: > Hi Ben, > > On 23/09/15 05:06, Scott Wood wrote: > > On Mon, 2015-09-21 at 16:47 +0100, Sudeep Holla wrote: > > > mpic_irq_set_wake return -ENXIO for non FSL MPIC and sets > > > IRQF_NO_SUSPEND > > > flag for FSL ones. enable_irq_wake already returns -ENXIO if irq_set_wak > > > is not implemented. Also there's no need to set the IRQF_NO_SUSPEND flag > > > as it doesn't guarantee wakeup for that interrupt. > > > > > > This patch removes the redundant mpic_irq_set_wake and sets the > > > IRQCHIP_SKIP_SET_WAKE for only FSL MPIC. > > > > > > Cc: Benjamin Herrenschmidt > > > Cc: Paul Mackerras > > > Cc: Michael Ellerman > > > Cc: Scott Wood > > > Cc: Hongtao Jia > > > Cc: Marc Zyngier > > > Cc: linuxppc-dev@lists.ozlabs.org > > > Signed-off-by: Sudeep Holla > > > --- > > > arch/powerpc/sysdev/mpic.c | 23 ++++------------------- > > > 1 file changed, 4 insertions(+), 19 deletions(-) > > > > Acked-by: Scott Wood > > > > Can you pick this up via your tree ? OK. -Scott