From: Punit Vara <punitvara@gmail.com>
To: JBottomley@odin.com
Cc: don.brace@pmcs.com, storagedev@pmcs.com, iss_storagedev@hp.com,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
Punit Vara <punitvara@gmail.com>
Subject: [PATCH 2/2] scsi: remove useless casting value returned by kmalloc to structure
Date: Sat, 24 Oct 2015 01:33:53 +0530 [thread overview]
Message-ID: <1445630633-14209-3-git-send-email-punitvara@gmail.com> (raw)
In-Reply-To: <1445630633-14209-1-git-send-email-punitvara@gmail.com>
This is the patch to the hpsa.c file that resolves following warning
reported by coccicheck:
WARNING: casting value returned by memory allocation function to
(BIG_IOCTL_Command_struct *) is useless.
Signed-off-by: Punit Vara <punitvara@gmail.com>
---
drivers/scsi/hpsa.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index 40669f8..8d971b3 100644
--- a/drivers/scsi/hpsa.c
+++ b/drivers/scsi/hpsa.c
@@ -6027,8 +6027,7 @@ static int hpsa_big_passthru_ioctl(struct ctlr_info *h, void __user *argp)
return -EINVAL;
if (!capable(CAP_SYS_RAWIO))
return -EPERM;
- ioc = (BIG_IOCTL_Command_struct *)
- kmalloc(sizeof(*ioc), GFP_KERNEL);
+ ioc = kmalloc(sizeof(*ioc), GFP_KERNEL);
if (!ioc) {
status = -ENOMEM;
goto cleanup1;
--
2.5.3
next prev parent reply other threads:[~2015-10-23 20:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-23 20:03 [PATCH 0/2] Fix warning by coccicheck Punit Vara
2015-10-23 20:03 ` [PATCH 1/2] scsi: lpfc: Use kzalloc instead of kmalloc Punit Vara
2015-10-23 23:26 ` Matthew R. Ochs
2015-10-25 9:17 ` punit vara
2015-10-23 20:03 ` Punit Vara [this message]
2015-10-23 23:27 ` [PATCH 2/2] scsi: remove useless casting value returned by kmalloc to structure Matthew R. Ochs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1445630633-14209-3-git-send-email-punitvara@gmail.com \
--to=punitvara@gmail.com \
--cc=JBottomley@odin.com \
--cc=don.brace@pmcs.com \
--cc=iss_storagedev@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=storagedev@pmcs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox