From: Mimi Zohar <zohar@linux.vnet.ibm.com>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: Peter Huewe <peterhuewe@gmx.de>,
Marcel Selhorst <tpmdd@selhorst.net>,
David Howells <dhowells@redhat.com>,
tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org, keyrings@vger.kernel.org,
chris.j.arges@canonical.com, seth.forshee@canonical.com,
colin.king@canonical.com, josh@joshtriplett.org,
Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
David Safford <safford@us.ibm.com>,
James Morris <james.l.morris@oracle.com>,
"Serge E. Hallyn" <serge@hallyn.com>
Subject: Re: [PATCH] keys, trusted: select TPM2 hash algorithm
Date: Sun, 25 Oct 2015 15:21:31 -0400 [thread overview]
Message-ID: <1445800891.3072.36.camel@linux.vnet.ibm.com> (raw)
In-Reply-To: <1445690562-11405-1-git-send-email-jarkko.sakkinen@linux.intel.com>
On Sat, 2015-10-24 at 15:42 +0300, Jarkko Sakkinen wrote:
> Added 'hashalg=' option for selecting the hash algorithm.
>
> Currently available options are:
>
> * sha1
> * sha256
> * sha384
> * sha512
> * sm3_256
Please consider using crypto/hash_info.c: hash_algo_name[], which
already define the algorithm string names. Use
include/crypto/hash_info.c to include a reference to this array.
Boot command line options should be prefixed with the subsystem name.
So instead of hashalg, please use tpm_hashalg. The boot command line
option needs to be documented in Documentation/kernel-parameters.txt.
Mimi
next prev parent reply other threads:[~2015-10-25 19:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-24 12:42 [PATCH] keys, trusted: select TPM2 hash algorithm Jarkko Sakkinen
2015-10-25 17:38 ` Jarkko Sakkinen
2015-10-25 19:21 ` Mimi Zohar [this message]
2015-10-26 5:44 ` Jarkko Sakkinen
2015-10-27 10:42 ` Jarkko Sakkinen
2015-10-27 13:54 ` Mimi Zohar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1445800891.3072.36.camel@linux.vnet.ibm.com \
--to=zohar@linux.vnet.ibm.com \
--cc=chris.j.arges@canonical.com \
--cc=colin.king@canonical.com \
--cc=dhowells@redhat.com \
--cc=james.l.morris@oracle.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jgunthorpe@obsidianresearch.com \
--cc=josh@joshtriplett.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=safford@us.ibm.com \
--cc=serge@hallyn.com \
--cc=seth.forshee@canonical.com \
--cc=tpmdd-devel@lists.sourceforge.net \
--cc=tpmdd@selhorst.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).