From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751989AbbJYTVq (ORCPT <rfc822;w@1wt.eu>);
	Sun, 25 Oct 2015 15:21:46 -0400
Received: from e28smtp06.in.ibm.com ([122.248.162.6]:59164 "EHLO
	e28smtp06.in.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751579AbbJYTVn (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sun, 25 Oct 2015 15:21:43 -0400
X-Helo: d28dlp01.in.ibm.com
X-MailFrom: zohar@linux.vnet.ibm.com
X-RcptTo: linux-security-module@vger.kernel.org
Message-ID: <1445800891.3072.36.camel@linux.vnet.ibm.com>
Subject: Re: [PATCH] keys, trusted: select TPM2 hash algorithm
From: Mimi Zohar <zohar@linux.vnet.ibm.com>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: Peter Huewe <peterhuewe@gmx.de>, Marcel Selhorst <tpmdd@selhorst.net>,
        David Howells <dhowells@redhat.com>, tpmdd-devel@lists.sourceforge.net,
        linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org,
        keyrings@vger.kernel.org, chris.j.arges@canonical.com,
        seth.forshee@canonical.com, colin.king@canonical.com,
        josh@joshtriplett.org,
        Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
        David Safford <safford@us.ibm.com>,
        James Morris <james.l.morris@oracle.com>,
        "Serge E. Hallyn" <serge@hallyn.com>
Date: Sun, 25 Oct 2015 15:21:31 -0400
In-Reply-To: <1445690562-11405-1-git-send-email-jarkko.sakkinen@linux.intel.com>
References: <1445690562-11405-1-git-send-email-jarkko.sakkinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.12.11 (3.12.11-1.fc21) 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
X-TM-AS-MML: disable
X-Content-Scanned: Fidelis XPS MAILER
x-cbid: 15102519-0021-0000-0000-00000818A02A
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, 2015-10-24 at 15:42 +0300, Jarkko Sakkinen wrote:
> Added 'hashalg=' option for selecting the hash algorithm.
> 
> Currently available options are:
> 
> * sha1
> * sha256
> * sha384
> * sha512
> * sm3_256

Please consider using crypto/hash_info.c: hash_algo_name[], which
already define the algorithm string names.  Use
include/crypto/hash_info.c to include a reference to this array.

Boot command line options should be prefixed with the subsystem name.
So instead of hashalg, please use tpm_hashalg.  The boot command line
option needs to be documented in Documentation/kernel-parameters.txt.

Mimi