From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965161AbbJ0SVo (ORCPT ); Tue, 27 Oct 2015 14:21:44 -0400 Received: from smtprelay0098.hostedemail.com ([216.40.44.98]:42514 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S964838AbbJ0SVm (ORCPT ); Tue, 27 Oct 2015 14:21:42 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 50,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::,RULES_HIT:41:355:379:541:599:967:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1431:1437:1515:1516:1518:1534:1542:1593:1594:1711:1730:1747:1777:1792:2393:2525:2560:2563:2682:2685:2828:2859:2892:2911:2933:2937:2939:2942:2945:2947:2951:2954:3022:3138:3139:3140:3141:3142:3354:3622:3865:3866:3867:3868:3870:3871:3872:3874:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4250:4321:4425:5007:6261:6691:7901:7903:8531:8957:9010:9025:10004:10400:10848:11232:11657:11658:11914:12043:12050:12517:12519:12555:12740:13018:13019:14096:14097:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: can62_e9687a3a7a18 X-Filterd-Recvd-Size: 3275 Message-ID: <1445970099.2757.22.camel@perches.com> Subject: Re: [PATCH] get_maintainer: Don't fallback to git by default From: Joe Perches To: Wolfram Sang Cc: Lee Jones , "Theodore Ts'o" , Javier Martinez Canillas , Laura Abbott , linux-kernel@vger.kernel.org, linux-kernel-owner@vger.kernel.org Date: Tue, 27 Oct 2015 11:21:39 -0700 In-Reply-To: <1445968175.2757.14.camel@perches.com> References: <1445897508-16528-1-git-send-email-javier@osg.samsung.com> <562EB07B.9040501@redhat.com> <562EC06C.5010404@osg.samsung.com> <20151027024729.GC16244@thunk.org> <20151027082150.GQ597@x1> <20151027092411.GA3405@katana> <20151027101022.GA5828@x1> <20151027102950.GB3405@katana> <1445968175.2757.14.camel@perches.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2015-10-27 at 10:49 -0700, Joe Perches wrote: > On Tue, 2015-10-27 at 11:29 +0100, Wolfram Sang wrote: > > > act as reviewers, they should have a mention in MAINTAINERS for > > > get_maintiner.pl to pull information from: > > > > > > R: Designated reviewer: FullName > > > These reviewers should be CCed on patches. > > > > I think this should do. > > > > Interested parties should start by scanning the mailing list :) > > I think the concept of reviewers is fine. > > A couple weeks ago, I suggested a mechanism to have reviewers > concentrate their entries into separate REVIEWERS file(s) > > https://lkml.org/lkml/2015/10/16/649 > > These REVIEWERS* files would also work for companies that have > people with specific areas of expertise that want internal review > before public exposure. > > Kconfig and Makefile files in directories like drivers/i2c/busses > are outliers because all new individual drivers are added to both > files. > > The mechanism to limit git-fallback use is a directory depth match. > > Wolfram has a MAINTAINERS entry of: > F: drivers/i2c/ > but that doesn't pattern doesn't match the directory depth of > file drivers/i2c/busses/Kconfig so git-fallback is used for files > that don't have specific MAINTAINERS. > > It _might_ make some sense to limit activation of git history in > that specific case, but for some path like arch/, that limitation > might _not_ make sense. Another option would be to add another pattern to the I2C section that matches all subdirectories of drivers/i2c/: --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index fb7d2e4..c670e1f 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -5104,6 +5104,7 @@ S: Maintained F: Documentation/devicetree/bindings/i2c/ F: Documentation/i2c/ F: drivers/i2c/ +F: drivers/i2c/*/ F: include/linux/i2c.h F: include/linux/i2c-*.h F: include/uapi/linux/i2c.h