From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754683AbbJ0Th3 (ORCPT ); Tue, 27 Oct 2015 15:37:29 -0400 Received: from smtprelay0230.hostedemail.com ([216.40.44.230]:37694 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754473AbbJ0Th2 (ORCPT ); Tue, 27 Oct 2015 15:37:28 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::,RULES_HIT:41:355:379:541:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:2896:3138:3139:3140:3141:3142:3352:3622:3865:3866:3868:3871:4321:5007:6261:7901:10004:10400:10848:11026:11473:11658:11914:12043:12296:12438:12517:12519:12740:13019:13069:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: elbow55_5dfcefb994a23 X-Filterd-Recvd-Size: 2182 Message-ID: <1445974644.2757.48.camel@perches.com> Subject: Re: [PATCH v2] PM / suspend: replacing printk From: Joe Perches To: Saurabh Sengar Cc: rjw@rjwysocki.net, pavel@ucw.cz, len.brown@intel.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Date: Tue, 27 Oct 2015 12:37:24 -0700 In-Reply-To: <1445973676-4394-1-git-send-email-saurabh.truth@gmail.com> References: <1445973676-4394-1-git-send-email-saurabh.truth@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2015-10-28 at 00:51 +0530, Saurabh Sengar wrote: > replacing prink(s) with appropriate pr_info and pr_err Removing the terminating newlines is likely incorrect. > diff --git a/kernel/power/suspend.c b/kernel/power/suspend.c [] > @@ -245,7 +245,7 @@ static int suspend_test(int level) > { > #ifdef CONFIG_PM_DEBUG > if (pm_test_level == level) { > - printk(KERN_INFO "suspend debug: Waiting for %d second(s).\n", > + pr_info("suspend debug: Waiting for %d second(s).", > pm_test_delay); > mdelay(pm_test_delay * 1000); > return 1; > @@ -317,7 +317,7 @@ static int suspend_enter(suspend_state_t state, bool *wakeup) > > error = dpm_suspend_late(PMSG_SUSPEND); > if (error) { > - printk(KERN_ERR "PM: late suspend of devices failed\n"); > + pr_err("PM: late suspend of devices failed"); > goto Platform_finish; > } > error = platform_suspend_prepare_late(state); > @@ -326,7 +326,7 @@ static int suspend_enter(suspend_state_t state, bool *wakeup) > > error = dpm_suspend_noirq(PMSG_SUSPEND); > if (error) { > - printk(KERN_ERR "PM: noirq suspend of devices failed\n"); > + pr_err("PM: noirq suspend of devices failed"); > goto Platform_early_resume; > } > error = platform_suspend_prepare_noirq(state);