From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932732AbbJ1JMe (ORCPT ); Wed, 28 Oct 2015 05:12:34 -0400 Received: from mail-pa0-f49.google.com ([209.85.220.49]:35409 "EHLO mail-pa0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932698AbbJ1JM2 (ORCPT ); Wed, 28 Oct 2015 05:12:28 -0400 From: Sudip Mukherjee To: gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org Subject: [PATCH v2 11/11] parport: avoid assignment in if Date: Wed, 28 Oct 2015 14:41:40 +0530 Message-Id: <1446023500-21292-12-git-send-email-sudipm.mukherjee@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1446023500-21292-1-git-send-email-sudipm.mukherjee@gmail.com> References: <1446023500-21292-1-git-send-email-sudipm.mukherjee@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It is not an usual practise to assign some value to a variable in the if test condition. Signed-off-by: Sudip Mukherjee --- drivers/parport/share.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/parport/share.c b/drivers/parport/share.c index b68f194..3308427 100644 --- a/drivers/parport/share.c +++ b/drivers/parport/share.c @@ -1120,7 +1120,8 @@ int parport_claim(struct pardevice *dev) /* Preempt any current device */ write_lock_irqsave(&port->cad_lock, flags); - if ((oldcad = port->cad) != NULL) { + oldcad = port->cad; + if (oldcad) { if (oldcad->preempt) { if (oldcad->preempt(oldcad->private)) goto blocked; -- 1.9.1