From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965447AbbJ1MqP (ORCPT ); Wed, 28 Oct 2015 08:46:15 -0400 Received: from smtprelay0018.hostedemail.com ([216.40.44.18]:37917 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755150AbbJ1MqO (ORCPT ); Wed, 28 Oct 2015 08:46:14 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 50,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::::,RULES_HIT:41:355:379:541:599:967:973:988:989:1260:1263:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2198:2199:2393:2525:2553:2560:2563:2682:2685:2828:2859:2911:2933:2937:2939:2942:2945:2947:2951:2954:3022:3138:3139:3140:3141:3142:3353:3622:3865:3866:3867:3868:3870:3871:3872:3874:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4321:4425:5007:6117:6119:6261:7903:7904:8985:9025:9388:10004:10049:10400:10848:11232:11658:11914:12043:12296:12517:12519:12555:12663:12679:12682:12740:12776:13069:13161:13229:13311:13357:14093:14096:14097:14106:14107:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: fish42_362103422ac57 X-Filterd-Recvd-Size: 3331 Message-ID: <1446036370.2757.104.camel@perches.com> Subject: Re: [PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag From: Joe Perches To: Lee Jones Cc: Javier Martinez Canillas , Krzysztof Kozlowski , Wolfram Sang , Linus Walleij , Sebastian Reichel , Linux Kernel , Chanwoo Choi , Mark Brown , Ben Dooks , "linux-arm-kernel@lists.infradead.org" Date: Wed, 28 Oct 2015 05:46:10 -0700 In-Reply-To: <20151028122417.GB4058@x1> References: <20151028082446.GF5828@x1> <20151028102832.GR5828@x1> <1446030399.2757.83.camel@perches.com> <20151028113932.GS5828@x1> <20151028121454.GA4058@x1> <1446034810.2757.87.camel@perches.com> <20151028122417.GB4058@x1> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2015-10-28 at 12:24 +0000, Lee Jones wrote: > On Wed, 28 Oct 2015, Joe Perches wrote: > > On Wed, 2015-10-28 at 12:14 +0000, Lee Jones wrote: > > > Ah, but wait. get_maintainer.pl *does* assume M means Maintainer > > > doesn't it? > > > > No, it looks at the "S:" line. > > Right. Then assumes because the driver is 'supported' or 'maintained' > that the person(s) listed in M: must be the Supporter(s) or the > Maintainer(s). Yup, except "assumes" isn't correct. It's your definition of maintainer that seems to be at odds with what's otherwise apparently commonly accepted. Any "M:" entry in a section where the "S:" line is maintained or supported is generally classified as a maintainer too. For instance: I think most accept that I am a maintainer of get_maintainer.pl. I wrote most of get_maintainer and I accept most but not all patches to it by acking some and nacking or otherwise requesting changes in others. I do not upstream it. I don't have a git tree at kernel.org and don't really need one. I rarely send pull requests. I generally upstream through Andrew Morton and he uses quilt. It's working well enough. The kernel summit thread from last year that initiated the "R:" line in MAINTAINERS was primarily focused on encouraging new patch review and honoring those that already take time to review. http://lists.linuxfoundation.org/pipermail/ksummit-discuss/2014-May/000764.html Knock your self out about clarifying how process should work. Generate consensus where necessary but don't try too hard. It's working reasonably well right now. Most people are able to maintain sanity by ignoring what's unimportant to them.