From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754987AbbJ1RIs (ORCPT ); Wed, 28 Oct 2015 13:08:48 -0400 Received: from smtprelay0178.hostedemail.com ([216.40.44.178]:44210 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751159AbbJ1RIq (ORCPT ); Wed, 28 Oct 2015 13:08:46 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::::::::,RULES_HIT:41:69:355:379:541:599:800:960:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2691:2828:3138:3139:3140:3141:3142:3352:3622:3865:3867:3868:3870:3872:3873:3874:4321:5007:6261:6742:10004:10400:10848:11026:11232:11658:11914:12043:12296:12517:12519:12663:12683:12740:13069:13311:13357:14096:14097:14110:21080:30054:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:3,LUA_SUMMARY:none X-HE-Tag: part86_11cbcaebadd49 X-Filterd-Recvd-Size: 2437 Message-ID: <1446052121.2757.120.camel@perches.com> Subject: Re: [PATCH] get_maintainer: Add subsystem to reviewer output From: Joe Perches To: Lee Jones Cc: Krzysztof Kozlowski , Andrew Morton , Uwe =?ISO-8859-1?Q?Kleine-K=F6nig?= , k.kozlowski.k@gmail.com, wsa@the-dreams.de, linus.walleij@linaro.org, Sebastian Reichel , linux-kernel@vger.kernel.org, Chanwoo Choi , broonie@kernel.org, ben-linux@fluff.org, linux-arm-kernel@lists.infradead.org Date: Wed, 28 Oct 2015 10:08:41 -0700 In-Reply-To: <20151028170116.GI4058@x1> References: <20151027172428.GB21070@earth> <20151027181555.GE5828@x1> <1445971482.2757.27.camel@perches.com> <20151028082446.GF5828@x1> <56309419.4060908@samsung.com> <20151028093907.GP4931@pengutronix.de> <20151028095524.GP5828@x1> <5630CA06.7050503@samsung.com> <1446050506.2757.109.camel@perches.com> <20151028170116.GI4058@x1> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2015-10-28 at 17:01 +0000, Lee Jones wrote: > On Wed, 28 Oct 2015, Joe Perches wrote: > > > Reviewer output currently does not include the subsystem > > that matched. Add it. > > > > Miscellanea: > > > > o Add a get_subsystem_name routine to centralize this > > > > Signed-off-by: Joe Perches > > --- > > scripts/get_maintainer.pl | 31 ++++++++++++++++--------------- > > 1 file changed, 16 insertions(+), 15 deletions(-) > > It looks like I'm going to have to drop the patch where we actually > start using the R: tag properly due to some social, emotional issues. Not to mention logical. > Despite that and not knowing Perl, I believe get_maintainer.pl should > be printing out the subsystem next to 'reviewer' as it does for > 'maintainer'. > > So with that in mind: > Acked-by: Lee Jones It'd be better if you could add a "tested-by:" instead.