From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964995AbbJ1WM5 (ORCPT ); Wed, 28 Oct 2015 18:12:57 -0400 Received: from smtprelay0112.hostedemail.com ([216.40.44.112]:57457 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S964919AbbJ1WM4 (ORCPT ); Wed, 28 Oct 2015 18:12:56 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2551:2553:2559:2562:2828:3138:3139:3140:3141:3142:3353:3622:3865:3867:3868:3870:3871:3872:4321:5007:6261:7903:10004:10400:10848:11026:11232:11473:11658:11914:12043:12050:12296:12438:12517:12519:12740:13019:13069:13141:13230:13311:13357:14096:14097:21080:30054:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: wheel63_367c9aea01924 X-Filterd-Recvd-Size: 2149 Message-ID: <1446070373.2757.147.camel@perches.com> Subject: Re: [PATCH] audit: removing unused variable From: Joe Perches To: Paul Moore Cc: Saurabh Sengar , eparis@redhat.com, linux-audit@redhat.com, linux-kernel@vger.kernel.org Date: Wed, 28 Oct 2015 15:12:53 -0700 In-Reply-To: <7739343.KgmgksQykM@sifl> References: <1446005434-4306-1-git-send-email-saurabh.truth@gmail.com> <7739343.KgmgksQykM@sifl> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2015-10-28 at 16:35 -0400, Paul Moore wrote: > On Wednesday, October 28, 2015 09:40:34 AM Saurabh Sengar wrote: > > variavle rc in not required as it is just used for unchanged for return, > > and return is always 0 in the function. [] > Thanks, applied with some spelling corrections to the description. As the return value is never actually tested, it seems better to make it a void function, > > diff --git a/kernel/audit.c b/kernel/audit.c [] > > @@ -686,23 +686,22 @@ static int audit_netlink_ok(struct sk_buff *skb, u16 > > msg_type) > > > > static int audit_log_common_recv_msg(struct audit_buffer **ab, u16 > > msg_type) { > > - int rc = 0; > > uid_t uid = from_kuid(&init_user_ns, current_uid()); > > pid_t pid = task_tgid_nr(current); > > > > if (!audit_enabled && msg_type != AUDIT_USER_AVC) { > > *ab = NULL; > > - return rc; > > + return 0; > > } > > > > *ab = audit_log_start(NULL, GFP_KERNEL, msg_type); > > if (unlikely(!*ab)) > > - return rc; > > + return 0; > > audit_log_format(*ab, "pid=%d uid=%u", pid, uid); > > audit_log_session_info(*ab); > > audit_log_task_context(*ab); > > > > - return rc; > > + return 0; > > } > > > > int is_audit_feature_set(int i) >