From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757075AbbJ2PYv (ORCPT ); Thu, 29 Oct 2015 11:24:51 -0400 Received: from mail-bl2on0136.outbound.protection.outlook.com ([65.55.169.136]:41663 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752133AbbJ2PYu (ORCPT ); Thu, 29 Oct 2015 11:24:50 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=scottwood@freescale.com; Message-ID: <1446132279.701.368.camel@freescale.com> Subject: Re: [V5, 2/6] fsl/fman: Add FMan support From: Scott Wood To: Liberman Igal-B31950 CC: "netdev@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" , "Bucur Madalin-Cristian-B32716" Date: Thu, 29 Oct 2015 10:24:39 -0500 In-Reply-To: References: <1442836354-5445-1-git-send-email-igal.liberman@freescale.com> <20150925230153.GA4626@home.buserror.net> <1446067854.701.365.camel@freescale.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.0-fta1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Originating-IP: [50.157.106.250] X-ClientProxiedBy: DM2PR21CA0027.namprd21.prod.outlook.com (25.161.137.165) To CY1PR03MB1485.namprd03.prod.outlook.com (25.163.17.158) X-Microsoft-Exchange-Diagnostics: 1;CY1PR03MB1485;2:no8MwnUbO0Oa7kiGcWzPrX0l0xjIcjZdFfAL95eM5ZEUBOI+JQB7faPujC9JXleCkm49SxDw6KCil0Ux0/MvE1qbpsLwfvnHq416EFIhhf6NWrBPIlYZ2lZqiUSVQ3WVRFiNLse4uXoqLGrzsk+ykHS2HxcZd7iz1TVznZX+t+Y=;3:EWM124qfPbtJRgPQ6oC5aYRMrQD/siYP9YAWmtIqLIR2/5LizV+Lsa/BvFrH+yiQoQf6nMMnhqKlXvyzNUhd6oS8uqArvV5TBkRt9+MNk4ndE1AQfbxEyFng8Sb29kA0xjhtMUR6AXUkQPSJddkq+w==;25:dmwCs9hxtS960+IlDMGXZVy9TkJLcH3xtvmzLZQncHNmfxe20AcZHvGl8MP5M618fw1xEaXBdFwCjswnwmpYoWnXHC3fsniSzBhaxxNK5SAOfd2UOfkayMnXI9EbDFRpIoGqbuBZkuDJjzF7KXUTbiQSwsAedye39yMSc30Ald9UoQU3ZwtDUDXnN4jYKyFvIc5oKdUyniPWmUdedMkh4ouVwiAYIw4rTPMa6dj2uO5CZMM9HTYcvrFGxbOoi7IlOwLoYqYkakoGq5PhA3X1Jw== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR03MB1485; X-Microsoft-Exchange-Diagnostics: 1;CY1PR03MB1485;20:m1Nygc0VQG1wuIPRD1I4noFSUrRbnrPhj0jIC3sBcRjSzRdHUvVfI02j03kr4B7HGsC3F2x8Mu7fy3Oqil9eXgqSaO1CSA3aqYpl6IMiNISW4Ods8d5Lo68dvxnHPzZP8huWNsQLCXydX05uJLrtg/v3cXk+vT0RIPS0KYNCPDe56Bq2kDGRD3YYJpjbJ1NXLu2FCudGdg3k7QGIlnxXb1h2DrpRZDm6UlVHydwMw4IESHrmzRgBKksY68O2NzIdXp5xmhFJy86vc7IEJcEUkVX3zU7adja1U6n/noJXvBiqz1isbrrJatYJSM9kg+V8cdhk+9uDuuHfk6WzQ9jX6Zb7CbCuNv0P6PvFfhOoVqZnbGjT3fV1MulxERzSMvQMr8SLHBfGcr2ZTTvSr2/9r19Qc/pQUW5eungvrjAeeVEokxyesawwfeyL+J6lzsMpfIWV3OzDQtZXxL6egLrdVJSPzi2UH763FKL6HsCAIKrsqA9rCM1MDiSVQbIEBlWC;4:8bf2zq+/pDbXFzDsqnbqx9CNmSaQzOA1A4b5x1XhKf7Yk41Bk2Redvsb79ql6dNZdj2vwqzYHS5z5L4+F3H5coag3ARE9C+mYrymaIYCWTKcf1paRnmGxUqnVWV8xnkR3dG4zEo6/A3GWEI7+U7mhOmXX65BgqxbGrFrWvPjOuVmZlamKp8OKDaKsS7QsIfsyM0Bjac8QvzQa/tGJtWM2GA4cOYCFvCxq8ys4P9dFjIPueJ66D/8GlFbdUL9e9y3W2/fLKAT55Qd2JofnPXVsf0GgJCFBdiYsNrwWL9MuRTx9ETezPCBdj3+bTm4nBbNW1xNyc+lylkfMaWprydvW7Oxu/c4AOp9bX63SjBV+63Ey0d9WKM0dwGK52LbGOpLygHeJMbdZnXfsrnT2hxhQA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(101931422205132); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(520078)(8121501046)(10201501046)(3002001)(102215026);SRVR:CY1PR03MB1485;BCL:0;PCL:0;RULEID:;SRVR:CY1PR03MB1485; X-Forefront-PRVS: 0744CFB5E8 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6009001)(377424004)(377454003)(24454002)(199003)(13464003)(189002)(33646002)(42186005)(4001150100001)(4001450100002)(101416001)(19580405001)(19580395003)(36756003)(50986999)(103116003)(76176999)(107886002)(97736004)(5820100001)(23676002)(5007970100001)(81156007)(5004730100002)(4001430100002)(110136002)(2950100001)(5001960100002)(92566002)(77096005)(66066001)(50466002)(86362001)(87976001)(105586002)(5001920100001)(47776003)(189998001)(50226001)(5008740100001)(122386002)(106356001)(40100003)(93886004)(99106002)(19627235001);DIR:OUT;SFP:1102;SCL:1;SRVR:CY1PR03MB1485;H:snotra.local;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTFQUjAzTUIxNDg1OzIzOko4aEVaeExmQUhoZVV3QXFvRE80ZmZKSmpa?= =?utf-8?B?ODcwMDkrTHNGMWRSWGtjSUY4UHJZVzJXenVZQXQ1cGVFNFdjRVRwOTFvNU1v?= =?utf-8?B?NnpiMVpnYXM4bWgxTG5lMnl2cWo0eHQvOU9XZ2w4ZlZrTE56RFI0cm1tNS96?= =?utf-8?B?MzNoc05tbDNxTml4S3ZNdGdha3ZSYjFhbms5NjdybVJ3VUVOZDMxdElMcXp4?= =?utf-8?B?bHpzdVNpRjFaaTFTUGhFaGdJKzljUVUvQ2tmaEl6bmNNRHFvUUNGZ1lHNitx?= =?utf-8?B?UU1KRTFJdEtKYU1tOXFRdUlROG02b3lyUjArK3ZWcHQyMTg3NGJQdEFGdEJu?= =?utf-8?B?aFYxUWJkTFAwbjJWSVFxNDVjcFFyT2pGTEorRUwrTHphcGxXNHF2OFhjSHZs?= =?utf-8?B?eHRnRnIyQnZ5eVd4eVh3aWhMZlFiOUd5dGpJK25vdkVTbTk1d1NRSHFvbkRT?= =?utf-8?B?MTFqc0FPYzVGTGJZRUE3cS9wbUdYTjU5QlZiM0JKaW1uMmZha1BuN0lzLzlF?= =?utf-8?B?dEI5ajU2Q0trbjRyR0M0S1hCSU9tUmFkQTVUMXVFM3NPYlJFbG9vUmlqTDJQ?= =?utf-8?B?SStUVHVrc3A1TlRYeENwUmMreThDSTE0OUcwcGJHZHNXRTMvK1RtbEdJUzR0?= =?utf-8?B?NnRpeXFsZzIvL1lYQUswbEpjNVc3c2JyTUNiNjd0OEp4azNQV1B0cWY3cjZ4?= =?utf-8?B?SVNVN2ZMNzgvMjdYbmRvbWNkQ1JzeGN0UGdJZTFpcHlkS3RiMjk0aWV5dFl5?= =?utf-8?B?SFVob1h5OTNNRVgvTjlMcDdpTjNka2FXeVVQcXlxRlJJMTkyNUxmM1dFRFBi?= =?utf-8?B?RFlZVHNveGFxcTFiNDNIVCtXOXlOYUF4NG1JRExPd1FxUWlJYTNzWU53NFVs?= =?utf-8?B?YUhnaEtpeW12cjAxNzJ1eEpjQjlMN2xoMGhTWSt1R0hhYkJFUkhkV2pQYXRD?= =?utf-8?B?VXQxLzVvSHh3WktlR1llZE1FZU05b0s5NTVHdXg5MWlYYTdzNnhraEpXblRX?= =?utf-8?B?YUdWN3FxbkdLUVd6eGIvN0xzM3JXVmhTa2RqTW5FSEN0OENFbW1OMkZSVDNm?= =?utf-8?B?NkxVaEovQ3Bad3ZrYXJVTmNLR0tkSWg5bDVFZ0dKYTNrTXVmNnBpZXprdThk?= =?utf-8?B?eElwUWV2QUkwVXJYSEx6OTUzMGtST2lFMG4vWnBCUm9MV24wRTVHL3Q1ajZn?= =?utf-8?B?ampmWTFNaG1ReHI3Qm5LaUtsb3pBWi9QckVuUkpVY3VpcldLMmY0QU1ndjdV?= =?utf-8?B?UGZvRG92UkhSVnpXcUVzTktWa05scFByTUpPNSt2YU96NWxBYXZ3QW1nL1JD?= =?utf-8?B?ZWJ3Z3ZWSGNwV2FUaHRVUWp4NWFBMjl2YzBKejdEajQ2V3FLTEdIZFR4cGN4?= =?utf-8?B?cDByaDRXYTljWFJDRDJLR2tsMVByQ2Npc3ZzckM0bVFlYkpHMVFzVU9penJm?= =?utf-8?B?aWwyLzVVV2tFbmNNdXoyVmhWNStjOUZheFdIbGgxNEVERWE1eDRmOCt3RTZG?= =?utf-8?B?VDRhL1gwRERBVytZaFNOYjBGM1p2T0UvNXlpdmQ0Y2EwdVp1Sm1kVGxJVUph?= =?utf-8?B?SHZlZTZCQ091VTZLVWVlczRONnkvR2E0WTdENitxM3hBamQ1aHM0MEptd0U2?= =?utf-8?B?OWxQVDQvSk5mTXBBSUxCUXBYT1BiR3VTYm9JaGxwSUswbGFsNHo3M2dySzVn?= =?utf-8?B?K3hYb2NrUHJVQXNEd0lWS2tQaFE3ZUZQSENURThlOFkrbGVJMTh4NU92YVcx?= =?utf-8?B?TkhzZWJqbng1bCtLaGtqUT09?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR03MB1485;5:hl3fsSEJwdvwMuwDcizApl2fOe5kC2O/hX7nBq4A75G+ORnY72nwLxvSqeGWHkW6cQAxWggqK5nYMkSdKIsiLZAM4DW9YvBgTnOiZO2XaT83w9gL6ce1VsAb48N6xM4YJV85TdiyX1ZljANrPVt2lA==;24:9MdX+2Vdp81S8N2m22w+/2Y8VDHIFHUQUofom4w3qDOwYzMGlvU8K6NmLbt61B5oZm0Fcd0IuJxZAcDAgwkOtTgodVftW0AGoUWB7hkT0pg=;20:HRz+OAJUoxEAi5a04Tr2Ne4tlmQkVmQ2NCfYCDChKi7pDBK3Yc2uB1eMd/AGkyoETuIybPByeggXk5LopKA5Ng== X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Oct 2015 15:24:47.7611 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR03MB1485 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2015-10-29 at 10:22 -0500, Liberman Igal-B31950 wrote: > Regards, > Igal Liberman > > > -----Original Message----- > > From: Wood Scott-B07421 > > Sent: Wednesday, October 28, 2015 11:31 PM > > To: Liberman Igal-B31950 > > Cc: netdev@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; linux- > > kernel@vger.kernel.org; Bucur Madalin-Cristian-B32716 > > > > Subject: Re: [V5, 2/6] fsl/fman: Add FMan support > > > > On Tue, 2015-10-27 at 11:32 -0500, Liberman Igal-B31950 wrote: > > > > > > > + > > > > > +struct device *fman_get_device(struct fman *fman) { return > > > > > +fman->dev; } > > > > > > > > Is this really necessary? > > > > > > > > > > Fman port needs fman->dev, fman structure is opaque, so yes, it's > > > needed. > > > > Why is opacity being maintained from one part of the fman driver to > > another? > > Isn't this the sort of excessive layering that was complained about? > > > > > > It's not really layering. > Fman Port uses Fman resources, it's not completely standalone. That's my point -- if it's not standalone, why is "struct fman" opaque to the port code? -Scott