Re: [PATCH v4 5/7] PCI: irqdomain: Look up IRQ domain by fwnode_handle

Andy Shevchenko
2015-10-30T00:28:24Z

On Fri, Oct 30, 2015 at 1:46 AM, <jakeo@microsoft.com> wrote:
> From: Jake Oshins <jakeo@microsoft.com>
>
> This patch adds a second way of finding an IRQ domain associated with
> a root PCI bus. After looking to see if one can be found through
> the OF tree, it attempts to look up the IRQ domain through an
> fwnode_handle stored in the pci_sysdata struct.

> +#ifdef CONFIG_PCI_MSI_IRQ_DOMAIN
> + /*
> + * If no IRQ domain was found via the OF tree, try looking it up
> + * directly through the fwnode_handle.
> + */
> + if (!d) {
> + if (pci_fwnode(bus)) {

Isn't it the same to
if (!d && pci_fwnode(bus))
d = ...

?

> + d = irq_find_matching_fwnode(pci_fwnode(bus),
> + DOMAIN_BUS_PCI_MSI);
> + }
> + }
> +#endif

--
With Best Regards,
Andy Shevchenko