RE: [PATCH v4 6/7] drivers:hv: Define the channel type for Hyper-V PCI Express pass-through

Jake Oshins
2015-10-30T16:13:48Z

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1569 bytes --]

> -----Original Message-----
> From: Andy Shevchenko [mailto:andy.shevchenko@gmail.com]
> Sent: Thursday, October 29, 2015 5:45 PM
> To: Jake Oshins <jakeo@microsoft.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>; KY Srinivasan
> <kys@microsoft.com>; linux-kernel@vger.kernel.org;
> devel@linuxdriverproject.org; olaf@aepfle.de; apw@canonical.com; Vitaly
> Kuznetsov <vkuznets@redhat.com>; tglx@redhat.com; Haiyang Zhang
> <haiyangz@microsoft.com>; marc.zyngier@arm.com; Jiang Liu
> <jiang.liu@linux.intel.com>; Bjorn Helgaas <bhelgaas@google.com>; linux-
> pci@vger.kernel.org
> Subject: Re: [PATCH v4 6/7] drivers:hv: Define the channel type for Hyper-V
> PCI Express pass-through
>
> >
> > /*
> > + * PCI Express Pass Through
> > + * {44C4F61D-4444-4400-9D52-802E27EDE19F}
> > + */
> > +
> > +#define HV_PCIE_GUID \
> > + .guid = { \
> > + 0x1D, 0xF6, 0xC4, 0x44, 0x44, 0x44, 0x00, 0x44, \
> > + 0x9D, 0x52, 0x80, 0x2E, 0x27, 0xED, 0xE1, 0x9F \
> > + }
>
> What about
> #include <linux/uuid.h>
>
> UUID_LE(...)
>
> And you may use uuid_le type instead of custom raw buffer.
>

Thanks. I was just following the form of all the others in this file. I think that this was done to match up with the representation that's coming across the VM boundary from Windows.

I do very much appreciate the feedback, though,
Jake Oshins
ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éÝ¶\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dÊ‡Ú™ë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥