RE: [PATCH v4 5/7] PCI: irqdomain: Look up IRQ domain by fwnode_handle

Jake Oshins
2015-10-30T16:13:18Z

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1609 bytes --]

> -----Original Message-----
> From: Andy Shevchenko [mailto:andy.shevchenko@gmail.com]
> Sent: Thursday, October 29, 2015 5:28 PM
> To: Jake Oshins <jakeo@microsoft.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>; KY Srinivasan
> <kys@microsoft.com>; linux-kernel@vger.kernel.org;
> devel@linuxdriverproject.org; olaf@aepfle.de; apw@canonical.com; Vitaly
> Kuznetsov <vkuznets@redhat.com>; tglx@redhat.com; Haiyang Zhang
> <haiyangz@microsoft.com>; marc.zyngier@arm.com; Jiang Liu
> <jiang.liu@linux.intel.com>; Bjorn Helgaas <bhelgaas@google.com>; linux-
> pci@vger.kernel.org
> Subject: Re: [PATCH v4 5/7] PCI: irqdomain: Look up IRQ domain by
> fwnode_handle
>
> On Fri, Oct 30, 2015 at 1:46 AM, <jakeo@microsoft.com> wrote:
> > From: Jake Oshins <jakeo@microsoft.com>
> >
> > This patch adds a second way of finding an IRQ domain associated with
> > a root PCI bus. After looking to see if one can be found through
> > the OF tree, it attempts to look up the IRQ domain through an
> > fwnode_handle stored in the pci_sysdata struct.
>
>
> > +#ifdef CONFIG_PCI_MSI_IRQ_DOMAIN
> > + /*
> > + * If no IRQ domain was found via the OF tree, try looking it up
> > + * directly through the fwnode_handle.
> > + */
> > + if (!d) {
> > + if (pci_fwnode(bus)) {
>
> Isn't it the same to
> if (!d && pci_fwnode(bus))
> d = ...
>

Thanks. I'll make this change and resend.

-- Jake Oshins
ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éÝ¶\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dÊ‡Ú™ë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥