From: Johannes Thumshirn <jthumshirn@suse.de>
To: Tina Ruchandani <ruchandani.tina@gmail.com>,
linux-scsi@vger.kernel.org, arnd@arndb.de
Cc: "James E.J. Bottomley" <JBottomley@odin.com>,
y2038@lists.linaro.org, linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH v3] scsi: stex: Remove use of struct timeval
Date: Fri, 30 Oct 2015 09:50:00 +0100 [thread overview]
Message-ID: <1446195000.16404.55.camel@suse.de> (raw)
In-Reply-To: <20151030083040.GA31741@tina-laptop>
Hi,
On Fri, 2015-10-30 at 01:30 -0700, Tina Ruchandani wrote:
> Function stex_gettime uses 'struct timeval' whose tv_sec value
> will overflow on 32-bit systems in year 2038 and beyond. This patch
> replaces the use of struct timeval and do_gettimeofday with
> ktime_get_real_seconds, which returns a 64-bit seconds value.
Thanks for the conversion. Can you please check if other (scsi) drivers
have the same y2038 issues? A quick "git grep do_gettimeofday
drivers/scsi/ | wc -l" reveals 30 occurrences (of cause not all are
problematic).
Other than that
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
next prev parent reply other threads:[~2015-10-30 8:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-30 8:30 [RESEND PATCH v3] scsi: stex: Remove use of struct timeval Tina Ruchandani
2015-10-30 8:50 ` Johannes Thumshirn [this message]
2015-10-30 8:54 ` Tina Ruchandani
2015-10-30 23:37 ` [Y2038] " Arnd Bergmann
2015-10-30 11:58 ` Hannes Reinecke
2015-10-30 12:45 ` Arnd Bergmann
2015-11-02 7:49 ` Hannes Reinecke
2015-11-05 16:23 ` [Y2038] " Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1446195000.16404.55.camel@suse.de \
--to=jthumshirn@suse.de \
--cc=JBottomley@odin.com \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=ruchandani.tina@gmail.com \
--cc=y2038@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox