Re: [RESEND PATCH v3] scsi: stex: Remove use of struct timeval

Hannes Reinecke
2015-11-02T07:49:59Z

On 10/30/2015 01:45 PM, Arnd Bergmann wrote:
> On Friday 30 October 2015 12:58:33 Hannes Reinecke wrote:
>>> @@ -1076,7 +1069,7 @@ static int stex_ss_handshake(struct st_hba *hba)
>>> h->req_cnt = cpu_to_le16(hba->rq_count+1);
>>> h->status_sz = cpu_to_le16(sizeof(struct status_msg));
>>> h->status_cnt = cpu_to_le16(hba->sts_count+1);
>>> - stex_gettime(&h->hosttime);
>>> + h->hosttime = cpu_to_le64(ktime_get_real_seconds());
>>> h->partner_type = HMU_PARTNER_TYPE;
>>> h->extra_offset = h->extra_size = 0;
>>> scratch_size = (hba->sts_count+1)*sizeof(u32);
>>>
>> Just remove 'hosttime' altogether. It serves no purpose whatsoever.
>>
>>
>
> Are you sure? It is defined in a struct that is shared with the HBA
> as part of hba->dma_mem, so unless you have access to the firmware,
> it's hard to guess what it might be used for inside of the firmware.
>
Ah, you're right. Okay, so we'll need to convert it.

Cheers,

Hannes