From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752869AbbJaIck (ORCPT <rfc822;w@1wt.eu>);
	Sat, 31 Oct 2015 04:32:40 -0400
Received: from mailgw02.mediatek.com ([218.249.47.111]:55613 "EHLO
	mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org
	with ESMTP id S1751576AbbJaIcg (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sat, 31 Oct 2015 04:32:36 -0400
X-Listener-Flag: 11101
Message-ID: <1446280350.13050.90.camel@mhfsdcap03>
Subject: Re: [PATCH v5 4/6] memory: mediatek: Add SMI driver
From: Yong Wu <yong.wu@mediatek.com>
To: Robin Murphy <robin.murphy@arm.com>
CC: Joerg Roedel <joro@8bytes.org>, Thierry Reding <treding@nvidia.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Will Deacon <will.deacon@arm.com>, Daniel Kurtz <djkurtz@google.com>,
        Tomasz Figa <tfiga@google.com>, Lucas Stach <l.stach@pengutronix.de>,
        Rob Herring <robh+dt@kernel.org>,
        Catalin Marinas <catalin.marinas@arm.com>,
        <linux-mediatek@lists.infradead.org>,
        Sasha Hauer <kernel@pengutronix.de>, <srv_heupstream@mediatek.com>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <iommu@lists.linux-foundation.org>, <pebolle@tiscali.nl>,
        <arnd@arndb.de>, <mitchelh@codeaurora.org>,
        Sricharan R <sricharan@codeaurora.org>, <youhua.li@mediatek.com>,
        <k.zhang@mediatek.com>, <kendrick.hsu@mediatek.com>
Date: Sat, 31 Oct 2015 16:32:30 +0800
In-Reply-To: <562F7B12.7030201@arm.com>
References: <1444357388-30257-1-git-send-email-yong.wu@mediatek.com>
	 <1444357388-30257-5-git-send-email-yong.wu@mediatek.com>
	 <562F7B12.7030201@arm.com>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.2.3-0ubuntu6 
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MTK: N
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 2015-10-27 at 13:24 +0000, Robin Murphy wrote:
> On 09/10/15 03:23, Yong Wu wrote:
> [...]
> > +static int mtk_smi_probe(struct platform_device *pdev)
> > +{
> > +	struct device *dev = &pdev->dev;
> > +	struct mtk_smi_data *smidata;
> > +	int ret;
> > +
> > +	if (!dev->pm_domain)
> > +		return -EPROBE_DEFER;
> > +
> > +	smidata = devm_kzalloc(dev, sizeof(*smidata), GFP_KERNEL);
> > +	if (!smidata)
> > +		return -ENOMEM;
> > +
> > +	smidata->clk_apb = devm_clk_get(dev, "apb");
> > +	if (IS_ERR(smidata->clk_apb))
> > +		return PTR_ERR(smidata->clk_apb);
> > +
> > +	smidata->clk_smi = devm_clk_get(dev, "smi");
> > +	if (IS_ERR(smidata->clk_smi))
> > +		return PTR_ERR(smidata->clk_smi);
> > +
> > +	pm_runtime_enable(dev);
> > +	dev_set_drvdata(dev, smidata);
> > +	return ret;
> 
> ret is used uninitialised here, but you might as well just "return 0;" 
> and get rid of the variable entirely.

Thanks. I will change to "return 0" directly.

> 
> > +}
> 
> Robin.
>