From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753408AbbJaMj1 (ORCPT ); Sat, 31 Oct 2015 08:39:27 -0400 Received: from smtprelay4.synopsys.com ([198.182.47.9]:49258 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751856AbbJaMjZ (ORCPT ); Sat, 31 Oct 2015 08:39:25 -0400 From: Alexey Brodkin To: "thiago.macieira@intel.com" CC: "mmarek@suse.com" , "linux-kernel@vger.kernel.org" Subject: make xconfig no longer works in Fedora Thread-Topic: make xconfig no longer works in Fedora Thread-Index: AQHRE9kqkDS8xc9eEU2b6iBKpVuyuw== Date: Sat, 31 Oct 2015 12:39:21 +0000 Message-ID: <1446295161.4394.81.camel@synopsys.com> Accept-Language: en-US, ru-RU Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.225.15.89] Content-Type: text/plain; charset="utf-8" Content-ID: MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id t9VCdtCB025030 Hi Thiago, I noticed that with your patch "Update the buildsystem for KConfig finding Qt" I cannot use "make xconfig" in Fedora 22 any longer. That's what I'm seeing: -------------------->8--------------------- $ make xconfig CHECK qt /bin/sh: line 1: qmake: command not found * * qmake failed. * make[1]: *** No rule to make target 'scripts/kconfig/.tmp_qtcheck', needed by 'scripts/kconfig/qconf.o'. Stop. Makefile:547: recipe for target 'xconfig' failed make: *** [xconfig] Error 2 -------------------->8--------------------- The reason why xconfig target fails is in Fedora (at least its recent versions) there's no "qmake". Instead there're "qmake-qt4" and/or "qmake-qt5" depending on which Qt packages are installed. I understand that there're plenty of possible workarounds like creating an alias qmake -> qmake-qtX, usage of "update-alternatives" etc. But IMHO it would be really nice if we don't break things that used to work. Still if I revert the patch in question "make xconfig" works again. And that's because we did autodiscovery of moc like that: -------------------->8--------------------- moc="\$$(shell pkg-config QtCore --variable=moc_location)"; -------------------->8--------------------- In my case it returns: -------------------->8--------------------- $ pkg-config QtCore --variable=moc_location /usr/lib64/qt4/bin/moc -------------------->8--------------------- If we do want to use "qmake" directly we may first find it similarly: -------------------->8--------------------- $ pkg-config QtCore --variable=exec_prefix /usr/lib64/qt4 -------------------->8--------------------- And then add "/bin/qmake" like this: -------------------->8--------------------- qmake="\$$(shell pkg-config QtCore --variable=exec_prefix""/bin/qmake"; -------------------->8--------------------- Regards, Alexey{.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I