Re: [PATCH 2/2] i2c: add driver for Sigma Designs SMP8642 I2C master

Wolfram Sang
2015-11-01T06:42:43Z

[-- Attachment #1: Type: text/plain, Size: 1116 bytes --]

On Sat, Oct 31, 2015 at 05:35:57PM +0000, Mans Rullgard wrote:
> This adds a driver for the Sigma Designs SMP8642 built-in I2C master
> controller. The hardware is very similar to the I2C controller in the
> Ralink RT3050 chip with the addition of interrupt generation and an
> inverted busy/idle status bit. There are typically two controllers with
> a shared IRQ.
>
> Signed-off-by: Mans Rullgard <mans@mansr.com>

Thanks for the driver. Same answer as here, though:

http://www.spinics.net/lists/linux-i2c/msg17001.html

> +#define TANGOX_I2C_CONFIG 0x00
> +#define TANGOX_I2C_CLKDIV 0x04
> +#define TANGOX_I2C_DEVADDR 0x08
> +#define TANGOX_I2C_ADDR 0x0c
> +#define TANGOX_I2C_DATAOUT 0x10
> +#define TANGOX_I2C_DATAIN 0x14
> +#define TANGOX_I2C_STATUS 0x18
> +#define TANGOX_I2C_STARTXFER 0x1c
> +#define TANGOX_I2C_BYTECNT 0x20
> +#define TANGOX_I2C_INT_EN 0x24
> +#define TANGOX_I2C_INT_STAT 0x28

The register set looks like the one from i2c-xlr.c, only that they are
32 bit apart instead of 8. Can you check if you can reuse that driver?

Thanks,

Wolfram

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]