linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] wireless:b43: remove last reference on B43_PCMCIA
@ 2015-11-02  9:24 Valentin Rothberg
  2015-11-02  9:31 ` Rafał Miłecki
  2015-11-02  9:50 ` [PATCH v2] " Valentin Rothberg
  0 siblings, 2 replies; 5+ messages in thread
From: Valentin Rothberg @ 2015-11-02  9:24 UTC (permalink / raw)
  To: zajec5; +Cc: kvalo, ziegler, linux-kernel, Valentin Rothberg

Remove last reference on Kconfig option B43_PCMCIA, which has been
removed by commit 399500da18f7 ("ssb: pick PCMCIA host code support from
b43 driver").

Signed-off-by: Valentin Rothberg <valentinrothberg@gmail.com>
---
 drivers/net/wireless/b43/main.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/net/wireless/b43/main.c b/drivers/net/wireless/b43/main.c
index ec013fbd6a81..190efd3160b7 100644
--- a/drivers/net/wireless/b43/main.c
+++ b/drivers/net/wireless/b43/main.c
@@ -5826,9 +5826,6 @@ static void b43_print_driverinfo(void)
 #ifdef CONFIG_B43_PCI_AUTOSELECT
 	feat_pci = "P";
 #endif
-#ifdef CONFIG_B43_PCMCIA
-	feat_pcmcia = "M";
-#endif
 #ifdef CONFIG_B43_PHY_N
 	feat_nphy = "N";
 #endif
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] wireless:b43: remove last reference on B43_PCMCIA
  2015-11-02  9:24 [PATCH] wireless:b43: remove last reference on B43_PCMCIA Valentin Rothberg
@ 2015-11-02  9:31 ` Rafał Miłecki
  2015-11-02  9:40   ` Valentin Rothberg
  2015-11-02  9:50 ` [PATCH v2] " Valentin Rothberg
  1 sibling, 1 reply; 5+ messages in thread
From: Rafał Miłecki @ 2015-11-02  9:31 UTC (permalink / raw)
  To: Valentin Rothberg; +Cc: Kalle Valo, Andreas Ziegler, Linux Kernel Mailing List

On 2 November 2015 at 10:24, Valentin Rothberg
<valentinrothberg@gmail.com> wrote:
> Remove last reference on Kconfig option B43_PCMCIA, which has been
> removed by commit 399500da18f7 ("ssb: pick PCMCIA host code support from
> b43 driver").
>
> Signed-off-by: Valentin Rothberg <valentinrothberg@gmail.com>
> ---
>  drivers/net/wireless/b43/main.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/drivers/net/wireless/b43/main.c b/drivers/net/wireless/b43/main.c
> index ec013fbd6a81..190efd3160b7 100644
> --- a/drivers/net/wireless/b43/main.c
> +++ b/drivers/net/wireless/b43/main.c
> @@ -5826,9 +5826,6 @@ static void b43_print_driverinfo(void)
>  #ifdef CONFIG_B43_PCI_AUTOSELECT
>         feat_pci = "P";
>  #endif
> -#ifdef CONFIG_B43_PCMCIA
> -       feat_pcmcia = "M";
> -#endif
>  #ifdef CONFIG_B43_PHY_N
>         feat_nphy = "N";
>  #endif

There is no point of leaving feat_pcmcia variable.

-- 
Rafał

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] wireless:b43: remove last reference on B43_PCMCIA
  2015-11-02  9:31 ` Rafał Miłecki
@ 2015-11-02  9:40   ` Valentin Rothberg
  0 siblings, 0 replies; 5+ messages in thread
From: Valentin Rothberg @ 2015-11-02  9:40 UTC (permalink / raw)
  To: Rafał Miłecki
  Cc: Kalle Valo, Andreas Ziegler, Linux Kernel Mailing List

On Nov 02 '15 10:31, Rafał Miłecki wrote:
> On 2 November 2015 at 10:24, Valentin Rothberg
> <valentinrothberg@gmail.com> wrote:
> > Remove last reference on Kconfig option B43_PCMCIA, which has been
> > removed by commit 399500da18f7 ("ssb: pick PCMCIA host code support from
> > b43 driver").
> >
> > Signed-off-by: Valentin Rothberg <valentinrothberg@gmail.com>
> > ---
> >  drivers/net/wireless/b43/main.c | 3 ---
> >  1 file changed, 3 deletions(-)
> >
> > diff --git a/drivers/net/wireless/b43/main.c b/drivers/net/wireless/b43/main.c
> > index ec013fbd6a81..190efd3160b7 100644
> > --- a/drivers/net/wireless/b43/main.c
> > +++ b/drivers/net/wireless/b43/main.c
> > @@ -5826,9 +5826,6 @@ static void b43_print_driverinfo(void)
> >  #ifdef CONFIG_B43_PCI_AUTOSELECT
> >         feat_pci = "P";
> >  #endif
> > -#ifdef CONFIG_B43_PCMCIA
> > -       feat_pcmcia = "M";
> > -#endif
> >  #ifdef CONFIG_B43_PHY_N
> >         feat_nphy = "N";
> >  #endif
> 
> There is no point of leaving feat_pcmcia variable.

Sorry, I will fix and resend the patch.

Thanks,
 Valentin

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH v2] wireless:b43: remove last reference on B43_PCMCIA
  2015-11-02  9:24 [PATCH] wireless:b43: remove last reference on B43_PCMCIA Valentin Rothberg
  2015-11-02  9:31 ` Rafał Miłecki
@ 2015-11-02  9:50 ` Valentin Rothberg
  2016-01-26 15:35   ` Rafał Miłecki
  1 sibling, 1 reply; 5+ messages in thread
From: Valentin Rothberg @ 2015-11-02  9:50 UTC (permalink / raw)
  To: zajec5; +Cc: kvalo, ziegler, linux-kernel, Valentin Rothberg

Remove last reference on Kconfig option B43_PCMCIA, which has been
removed by commit 399500da18f7 ("ssb: pick PCMCIA host code support from
b43 driver").

Signed-off-by: Valentin Rothberg <valentinrothberg@gmail.com>
---
 drivers/net/wireless/b43/main.c | 13 ++++---------
 1 file changed, 4 insertions(+), 9 deletions(-)

diff --git a/drivers/net/wireless/b43/main.c b/drivers/net/wireless/b43/main.c
index ec013fbd6a81..524e5f4a07dd 100644
--- a/drivers/net/wireless/b43/main.c
+++ b/drivers/net/wireless/b43/main.c
@@ -5820,15 +5820,12 @@ void b43_controller_restart(struct b43_wldev *dev, const char *reason)
 
 static void b43_print_driverinfo(void)
 {
-	const char *feat_pci = "", *feat_pcmcia = "", *feat_nphy = "",
-		   *feat_leds = "", *feat_sdio = "";
+	const char *feat_pci = "", *feat_nphy = "", *feat_leds = "",
+		   *feat_sdio = "";
 
 #ifdef CONFIG_B43_PCI_AUTOSELECT
 	feat_pci = "P";
 #endif
-#ifdef CONFIG_B43_PCMCIA
-	feat_pcmcia = "M";
-#endif
 #ifdef CONFIG_B43_PHY_N
 	feat_nphy = "N";
 #endif
@@ -5838,10 +5835,8 @@ static void b43_print_driverinfo(void)
 #ifdef CONFIG_B43_SDIO
 	feat_sdio = "S";
 #endif
-	printk(KERN_INFO "Broadcom 43xx driver loaded "
-	       "[ Features: %s%s%s%s%s ]\n",
-	       feat_pci, feat_pcmcia, feat_nphy,
-	       feat_leds, feat_sdio);
+	printk(KERN_INFO "Broadcom 43xx driver loaded [ Features: %s%s%s%s ]\n",
+	       feat_pci, feat_nphy, feat_leds, feat_sdio);
 }
 
 static int __init b43_init(void)
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH v2] wireless:b43: remove last reference on B43_PCMCIA
  2015-11-02  9:50 ` [PATCH v2] " Valentin Rothberg
@ 2016-01-26 15:35   ` Rafał Miłecki
  0 siblings, 0 replies; 5+ messages in thread
From: Rafał Miłecki @ 2016-01-26 15:35 UTC (permalink / raw)
  To: Valentin Rothberg; +Cc: Kalle Valo, Andreas Ziegler, Linux Kernel Mailing List

On 2 November 2015 at 10:50, Valentin Rothberg
<valentinrothberg@gmail.com> wrote:
> Remove last reference on Kconfig option B43_PCMCIA, which has been
> removed by commit 399500da18f7 ("ssb: pick PCMCIA host code support from
> b43 driver").

Please resend this patch using b43-dev@ and linux-wireless@ mailing
lists as stated in MAINTAINERS.

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2016-01-26 15:36 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-02  9:24 [PATCH] wireless:b43: remove last reference on B43_PCMCIA Valentin Rothberg
2015-11-02  9:31 ` Rafał Miłecki
2015-11-02  9:40   ` Valentin Rothberg
2015-11-02  9:50 ` [PATCH v2] " Valentin Rothberg
2016-01-26 15:35   ` Rafał Miłecki

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).