public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Taeung Song <treeze.taeung@gmail.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: linux-kernel@vger.kernel.org, jolsa@redhat.com,
	namhyung@kernel.org, Ingo Molnar <mingo@redhat.com>,
	Taeung Song <treeze.taeung@gmail.com>
Subject: [PATCH v9 4/9] perf config: Add comparing name treating '_' and '-' as being the same thing.
Date: Tue,  3 Nov 2015 10:50:15 +0900	[thread overview]
Message-ID: <1446515420-22681-5-git-send-email-treeze.taeung@gmail.com> (raw)
In-Reply-To: <1446515420-22681-1-git-send-email-treeze.taeung@gmail.com>

The comparing name functionality is that
two config name are compared treating '-' or '_' as
being the same thing. For example, both 'print_percent'
and 'print-percent' in 'call-graph' section
are regarded as the same thing.

Signed-off-by: Taeung Song <treeze.taeung@gmail.com>
---
 tools/perf/builtin-config.c | 23 ++++++++++++++++++++++-
 1 file changed, 22 insertions(+), 1 deletion(-)

diff --git a/tools/perf/builtin-config.c b/tools/perf/builtin-config.c
index f99c39d..d4e2899 100644
--- a/tools/perf/builtin-config.c
+++ b/tools/perf/builtin-config.c
@@ -32,6 +32,27 @@ static struct option config_options[] = {
 	OPT_END()
 };
 
+static int compare_name(const char *name1, const char *name2)
+{
+	while (true) {
+		/*
+		 * If two names have '-' or '_', them are treated
+		 * as being the same thing.
+		 */
+		if ((*name1 == '-' || *name1 == '_')
+		    && (*name2 == '-' || *name2 == '_')) {
+			name1++, name2++;
+			continue;
+		}
+
+		if (*name1 && (*name1 == *name2))
+			name1++, name2++;
+		else
+			break;
+	}
+	return *(const unsigned char *)name1-*(const unsigned char *)name2;
+}
+
 static struct config_section *find_section(struct list_head *sections,
 					   const char *section_name)
 {
@@ -50,7 +71,7 @@ static struct config_element *find_element(const char *name,
 	struct config_element *element;
 
 	list_for_each_entry(element, &section->element_head, list)
-		if (!strcmp(element->name, name))
+		if (!compare_name(element->name, name))
 			return element;
 
 	return NULL;
-- 
1.9.1


  parent reply	other threads:[~2015-11-03  1:50 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-03  1:50 [PATCH v9 0/9] perf tools: Add 'perf-config' command Taeung Song
2015-11-03  1:50 ` [PATCH v9 1/9] " Taeung Song
2015-11-03 11:36   ` Namhyung Kim
2015-11-03 15:40   ` Arnaldo Carvalho de Melo
2015-11-05 10:19     ` Taeung Song
2015-11-03  1:50 ` [PATCH v9 2/9] perf config: Add '--system' and '--user' options to select which config file is used Taeung Song
2015-11-03 11:49   ` Namhyung Kim
2015-11-03  1:50 ` [PATCH v9 3/9] perf config: Collect configs to handle config variables Taeung Song
2015-11-03 12:10   ` Namhyung Kim
2015-11-03  1:50 ` Taeung Song [this message]
2015-11-03 12:15   ` [PATCH v9 4/9] perf config: Add comparing name treating '_' and '-' as being the same thing Namhyung Kim
2015-11-03  1:50 ` [PATCH v9 5/9] perf config: Add a option 'list-all' to perf-config Taeung Song
2015-11-03 12:29   ` Namhyung Kim
2015-11-03  1:50 ` [PATCH v9 6/9] perf config: Add 'get' functionaliy Taeung Song
2015-11-03  1:50 ` [PATCH v9 7/9] perf config: Add 'set' feature Taeung Song
2015-11-03  1:50 ` [PATCH v9 8/9] perf config: normalize a value depending on default type of it Taeung Song
2015-11-03  1:50 ` [PATCH v9 9/9] perf config: Add a option 'remove' to perf-config Taeung Song

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1446515420-22681-5-git-send-email-treeze.taeung@gmail.com \
    --to=treeze.taeung@gmail.com \
    --cc=acme@kernel.org \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox