From: Sinan Kaya <okaya@codeaurora.org>
To: linux-scsi@vger.kernel.org, timur@codeaurora.org,
cov@codeaurora.org, jcm@redhat.com
Cc: Sinan Kaya <okaya@codeaurora.org>,
Doug Gilbert <dgilbert@interlog.com>,
"James E.J. Bottomley" <JBottomley@odin.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH 3/4] scsi: fix compiler warning for sg
Date: Wed, 4 Nov 2015 23:46:28 -0500 [thread overview]
Message-ID: <1446698789-19308-3-git-send-email-okaya@codeaurora.org> (raw)
In-Reply-To: <1446698789-19308-1-git-send-email-okaya@codeaurora.org>
The MULDIV macro has been designed for small
numbers. It emits an overflow warning on 64 bit
systems. This patch places type casts in the
parameters to fix the compiler warning.
Signed-off-by: Sinan Kaya <okaya@codeaurora.org>
---
drivers/scsi/sg.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/sg.c b/drivers/scsi/sg.c
index 9d7b7db..eb2739d 100644
--- a/drivers/scsi/sg.c
+++ b/drivers/scsi/sg.c
@@ -88,7 +88,10 @@ static void sg_proc_cleanup(void);
* Of course an overflow is inavoidable if the result of muldiv doesn't fit
* in 32 bits.
*/
-#define MULDIV(X,MUL,DIV) ((((X % DIV) * MUL) / DIV) + ((X / DIV) * MUL))
+static inline u64 MULDIV(u64 X, u32 MUL, u32 DIV)
+{
+ return ((((X % DIV) * MUL) / DIV) + ((X / DIV) * MUL));
+}
#define SG_DEFAULT_TIMEOUT MULDIV(SG_DEFAULT_TIMEOUT_USER, HZ, USER_HZ)
--
Qualcomm Technologies, Inc. on behalf of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2015-11-05 4:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-05 4:46 [PATCH 1/4] scsi: mpt2sas: try 64 bit DMA when 32 bit DMA fails Sinan Kaya
2015-11-05 4:46 ` [PATCH 2/4] scsi: mpt3sas: " Sinan Kaya
2015-11-05 4:46 ` Sinan Kaya [this message]
2015-11-05 5:39 ` [PATCH 3/4] scsi: fix compiler warning for sg kbuild test robot
2015-11-05 6:40 ` kbuild test robot
2015-11-05 6:51 ` kbuild test robot
2015-11-05 8:48 ` Andy Shevchenko
2015-11-05 15:10 ` Sinan Kaya
2015-11-05 15:25 ` Timur Tabi
2015-11-05 18:07 ` Andy Shevchenko
2015-11-05 18:32 ` Sinan Kaya
2015-11-05 19:31 ` Andy Shevchenko
2015-11-05 19:56 ` Andy Shevchenko
2015-11-05 20:16 ` Sinan Kaya
2015-11-09 1:17 ` Sinan Kaya
2015-11-05 4:46 ` [PATCH 4/4] scsi: mptxsas: offload IRQ execution Sinan Kaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1446698789-19308-3-git-send-email-okaya@codeaurora.org \
--to=okaya@codeaurora.org \
--cc=JBottomley@odin.com \
--cc=cov@codeaurora.org \
--cc=dgilbert@interlog.com \
--cc=jcm@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=timur@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox