Re: [PATCH 17/25] perf stat report: Move csv_sep initialization before report command

Jiri Olsa
2015-12-17T19:46:45Z

On Thu, Dec 17, 2015 at 03:57:07PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Thu, Nov 05, 2015 at 03:41:01PM +0100, Jiri Olsa escreveu:
> > So we have csv_sep properly initialized before
> > report command leg.
>
> I moved this to before "perf stat report: Process stat and stat round
> events" so that what you wrote above makes sense, i.e. after this patch
> nothing is produced by 'perf stat report' and right after the stat and
> stat round one is applied I get:
>
> [acme@ssdandy linux]$ perf stat report
>
> Performance counter stats for '/home/acme/bin/perf stat record usleep 1':
>
> 0.411636 task-clock (msec) # 0.571 CPUs utilized
> 2 context-switches # 0.005 M/sec
> 0 cpu-migrations # 0.000 K/sec
> 149 page-faults # 0.362 M/sec
> 1,291,807 cycles # 3.138 GHz
> 959,632 stalled-cycles-frontend # 74.29% frontend cycles idle
> 703,170 stalled-cycles-backend # 54.43% backend cycles idle
> 757,538 instructions # 0.59 insns per cycle
> # 1.27 stalled cycles per insn
> 133,293 branches # 323.813 M/sec
> <not counted> branch-misses (0.00%)
>
> 0.000720394 seconds time elapsed
>
> [acme@ssdandy linux]$
>
> And not this ugly thing:
>
> [acme@ssdandy linux]$ perf stat report
>
> Performance counter stats for '/home/acme/bin/perf stat record usleep 1':
>
> 0.411636(null) (null)task-clock (msec) # 0.571 CPUs utilized
> 2(null) (null)context-switches # 0.005 M/sec
> 0(null) (null)cpu-migrations # 0.000 K/sec
> 149(null) (null)page-faults # 0.362 M/sec
> 1,291,807(null) (null)cycles # 3.138 GHz
> 959,632(null) (null)stalled-cycles-frontend # 74.29% frontend cycles idle
> 703,170(null) (null)stalled-cycles-backend # 54.43% backend cycles idle
> 757,538(null) (null)instructions # 0.59 insns per cycle
> # 1.27 stalled cycles per insn
> 133,293(null) (null)branches # 323.813 M/sec
> <not counted>(null) (null)branch-misses (0.00%)
>
> 0.000720394 seconds time elapsed
>
> [acme@ssdandy linux]$

sounds good, thanks

jirka