public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Caesar Wang <wxt@rock-chips.com>
To: Heiko Stuebner <heiko@sntech.de>, Mark Brown <broonie@kernel.org>
Cc: kmixter@chromium.org, Sonny Rao <sonnyrao@chromium.org>,
	Doug Anderson <dianders@chromium.org>,
	linux-rockchip@lists.infradead.org,
	Dylan Reid <dgreid@chromium.org>,
	benchan@chromium.org, Cheng-Yi Chiang <cychiang@chromium.org>,
	Caesar Wang <wxt@rock-chips.com>,
	Jaroslav Kysela <perex@perex.cz>,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
	Takashi Iwai <tiwai@suse.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 0/3] Support more sample rates, let the rates normal work
Date: Fri,  6 Nov 2015 19:38:13 +0800	[thread overview]
Message-ID: <1446809896-11254-1-git-send-email-wxt@rock-chips.com> (raw)

That's seem the moment rockchip-codec driver other than 44100 and 48000
do not work.
Says the (max98090, rt5640).

----
As the chromeos reported
issue:(https://chromium.googlesource.com/chromiumos/third_party/kernel/+/v3.14)

For detail:
        In that bug we want to add 32000 to
        sound/soc/rockchip/rockchip_max98090.c rk_aif1_hw_params.
        However that does not work.

        Previously, in
        https://chromium-review.googlesource.com/#/c/268398/ , rate
        8000, 1600, 96000 were added.
        However, those rates do not work. I got the same audio as 48000
        when I run

        aplay -D hw:0,0
        /usr/local/autotest/cros/audio/fix_440_16_half.raw --rate 8000
        -f S16_LE -c2
        aplay -D hw:0,0
        /usr/local/autotest/cros/audio/fix_440_16_half.raw --rate 16000
        -f S16_LE -c2
        aplay -D hw:0,0
        /usr/local/autotest/cros/audio/fix_440_16_half.raw --rate 96000
        -f S16_LE -c2

        They all sound identical to
        aplay -D hw:0,0
        /usr/local/autotest/cros/audio/fix_440_16_half.raw --rate 48000
        -f S16_LE -c2

        Also, recording using
        aplay -D hw:0,0 /usr/local/test.raw --rate 96000 -f S16_LE -c2
        and examine the output we see it was recording using 48000.

        Okay, let's add this series patchs to fix this issue.

        arecord -D hw:0 -f S16_LE -c 2 --rate [8000-96000] -d 5 foobar.wav
        and
            aplay -D hw:0 foobar.wav
Tested on veyron devices.


Changes in v2:
- move the set clock divider into rockchip i2s.
- add the 64000 sample rates for max98090.
- add the 64000 sample rate for rt5645.

Caesar Wang (3):
  ASoC: rockchip: i2s: change bclk and lrck according to sample rates
  ASoC: rockchip-max98090: Allow more sample rates
  ASoC: rockchip-rt5645: Allow more sample rates

 sound/soc/rockchip/rockchip_i2s.c      | 23 +++++++++++++++++++++++
 sound/soc/rockchip/rockchip_max98090.c |  6 ++++++
 sound/soc/rockchip/rockchip_rt5645.c   |  6 ++++++
 3 files changed, 35 insertions(+)

-- 
1.9.1


             reply	other threads:[~2015-11-06 11:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-06 11:38 Caesar Wang [this message]
2015-11-06 11:38 ` [PATCH v2 1/3] ASoC: rockchip: i2s: change bclk and lrck according to sample rates Caesar Wang
2015-11-06 11:38 ` [PATCH v2 2/3] ASoC: rockchip-max98090: Allow more " Caesar Wang
2015-11-06 11:38 ` [PATCH v2 3/3] ASoC: rockchip-rt5645: " Caesar Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1446809896-11254-1-git-send-email-wxt@rock-chips.com \
    --to=wxt@rock-chips.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=benchan@chromium.org \
    --cc=broonie@kernel.org \
    --cc=cychiang@chromium.org \
    --cc=dgreid@chromium.org \
    --cc=dianders@chromium.org \
    --cc=heiko@sntech.de \
    --cc=kmixter@chromium.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=perex@perex.cz \
    --cc=sonnyrao@chromium.org \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox