From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161441AbbKFM0s (ORCPT ); Fri, 6 Nov 2015 07:26:48 -0500 Received: from mailout4.samsung.com ([203.254.224.34]:43050 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161339AbbKFM0o (ORCPT ); Fri, 6 Nov 2015 07:26:44 -0500 X-AuditID: cbfee691-f79d66d000001509-5a-563c9c813d77 From: Vishnu Pratap Singh To: axboe@kernel.dk, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, jmoyer@redhat.com, minchan@kernel.org, ngupta@vflare.org, sergey.senozhatsky.work@gmail.com, davem@davemloft.net, neilb@suse.com, ulf.hansson@linaro.org, tiwai@suse.de, hare@suse.de, ming.lei@canonical.com, jarod@redhat.com, viro@zeniv.linux.org.uk, tj@kernel.org, adrian.hunter@intel.com, jonathanh@nvidia.com, grundler@chromium.org, linux-ide@vger.kernel.org, linux-raid@vger.kernel.org, linux-mmc@vger.kernel.org Cc: cpgs@samsung.com, vishu13285@gmail.com, pintu.k@samsung.com, rohit.kr@samsung.com, Vishnu Pratap Singh Subject: [PATCH 2/8] mmc: handle add_disk() return value Date: Fri, 06 Nov 2015 17:52:09 +0530 Message-id: <1446812535-10567-2-git-send-email-vishnu.ps@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1446812535-10567-1-git-send-email-vishnu.ps@samsung.com> References: <437969438-9181-1-git-send-email-vishnu.ps@samsung.com> <1446812535-10567-1-git-send-email-vishnu.ps@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrEIsWRmVeSWpSXmKPExsWyRsSkVrdxjk2Ywb+lhhYnn6xhs5izHkis vtvPZvHykKbFnPMtLBavjvxgstizaBKTxbSeS4wWZ39dZbFombWIxeLYjkdMFpd3zWGzOPK/ n9Giff4uRotlX9+zW+x6+J3d4tPGWIsNLbPYLfq+H2a3eN7cymLxaALQkJeb3zBZ/Fp+lNHi +Npwi/N/j7NaTOm7y2ixZcVDVgdpj1kNvWwesxsusnhsWXmTyWPnrLvsHov3vGTyuHy21GPT qk42jzvX9rB5nJjxm8Wjt/kdm8f7fVfZPPq2rGL0WL/lKovH5tPVHjs/bWb1+LxJLkAwissm JTUnsyy1SN8ugSvj3Ifogj8cFacWnmJrYNzJ3sXIySEhYCJx4fJKNghbTOLCvfVANheHkMAK Ronlv/sYYYrutS5mhEgsZZT4sfgkO4TTxCRx8OIzsHY2AUOJDbOPgCVEBH4zS8xY0A/mMAu0 MEpMPb2OCaRKWMBC4ui9aawgNouAqkTjqf1gNq+Aq8Sq1XeYIPbJSZw8NhkozsHBKeAm8fAw WFhIoF7iz4QdYDMlBH5wSLTe7oSaIyDxbfIhFpB6CQFZiU0HmCHGSEocXHGDZQKj8AJGhlWM oqkFyQXFSelFpnrFibnFpXnpesn5uZsYgUnh9L9nE3cw3j9gfYhRgINRiYfXYLl1mBBrYllx Ze4hRlOgDROZpUST84GpJ68k3tDYzMjC1MTU2Mjc0kxJnFdH+mewkEB6YklqdmpqQWpRfFFp TmrxIUYmDk6pBkaBkLedC227hBiuKf5meWrKwlS++JrGdcu9V8LmK3m/z/baYetzqcU74Nzf ZQwFkTqBX/dem9jtzR6QbX7RRGwBg9OVPtWCPW+WBu9RjTPN1+TyvjpJsuFXkAG3SvoRZ7dD zzyVxCdL2bS/D1varZslMplh7sNkocL1h6Z1Meeqts6oS3JWUmIpzkg01GIuKk4EAIapmHwF AwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrPKsWRmVeSWpSXmKPExsVy+t9jAd3GOTZhBr/vqFucfLKGzWLOeiCx +m4/m8XLQ5oWc863sFi8OvKDyWLPoklMFtN6LjFanP11lcWiZdYiFotjOx4xWVzeNYfN4sj/ fkaL9vm7GC2WfX3PbrHr4Xd2i08bYy02tMxit+j7fpjd4nlzK4vFowlAQ15ufsNk8Wv5UUaL 42vDLc7/Pc5qMaXvLqPFlhUPWR2kPWY19LJ5zG64yOKxZeVNJo+ds+6yeyze85LJ4/LZUo9N qzrZPO5c28PmcWLGbxaP3uZ3bB7v911l8+jbsorRY/2Wqywem09Xe+z8tJnV4/MmuQDBqAZG m4zUxJTUIoXUvOT8lMy8dFsl7+B453hTMwNDXUNLC3MlhbzE3FRbJRefAF23zBxg6CgplCXm lAKFAhKLi5X07TBNCA1x07WAaYzQ9Q0JgusxMkADCWsYM859iC74w1FxauEptgbGnexdjJwc EgImEvdaFzNC2GISF+6tZ+ti5OIQEljKKPFj8Ul2CKeJSeLgxWdsIFVsAoYSG2YfAUuICPxm lpixoB/MYRZoYZSYenodE0iVsICFxNF701hBbBYBVYnGU/vBbF4BV4lVq+8wQeyTkzh5bDJQ nIODU8BN4uFhsLCQQL3Enwk72Ccw8i5gZFjFKJFakFxQnJSea5iXWq5XnJhbXJqXrpecn7uJ EZx4nkntYDy4y/0QowAHoxIPr8Fy6zAh1sSy4srcQ4wSHMxKIrxyzDZhQrwpiZVVqUX58UWl OanFhxhNge6ayCwlmpwPTIp5JfGGxibmpsamliYWJmaWSuK8+p5GYUIC6YklqdmpqQWpRTB9 TBycUg2Mkv8Yp1iaBlpnGn/y6Jq4hClVSyzs99LaDVOFjjmvXmI8eeq5eEZud4mLZrPlJ//i WrVd+ZTuY+eauV1ikVP+Hla84VPPc/aT1sYbbD91ePRLxeM2TovZ28Uz+XBQSJVxeO/Rn6Fd t66c/HDJfv3Nib4mURMzbn1euG/R6TILh5zzG3dmv+Leo8RSnJFoqMVcVJwIAKa9/l5SAwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch handles add_disk() return value. Earlier add_disk() function doesn't handle error cases, now it is added, so the callers of this function should also handle it. Verfied on X86 based ubuntu machine. This patch depends on [PATCH 1/8] block/genhd.c: Add error handling Signed-off-by: Vishnu Pratap Singh --- drivers/mmc/card/block.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/card/block.c b/drivers/mmc/card/block.c index 23b6c8e..543c670 100644 --- a/drivers/mmc/card/block.c +++ b/drivers/mmc/card/block.c @@ -2432,7 +2432,10 @@ static int mmc_add_disk(struct mmc_blk_data *md) int ret; struct mmc_card *card = md->queue.card; - add_disk(md->disk); + ret = add_disk(md->disk); + if (ret) + goto add_disk_fail; + md->force_ro.show = force_ro_show; md->force_ro.store = force_ro_store; sysfs_attr_init(&md->force_ro.attr); @@ -2468,7 +2471,7 @@ power_ro_lock_fail: device_remove_file(disk_to_dev(md->disk), &md->force_ro); force_ro_fail: del_gendisk(md->disk); - +add_disk_fail: return ret; } -- 1.9.1