Re: [PATCH 02/23] ARM: dts: n950: add display support

Laurent Pinchart
2016-03-17T16:43:08Z

Hi Sebastian,

Thank you for the patch.

On Tuesday 08 March 2016 17:39:34 Sebastian Reichel wrote:
> Signed-off-By: Sebastian Reichel <sre@kernel.org>
> ---
> arch/arm/boot/dts/omap3-n950.dts | 71 +++++++++++++++++++++++++++++++++++++
> 1 file changed, 71 insertions(+)
>
> diff --git a/arch/arm/boot/dts/omap3-n950.dts
> b/arch/arm/boot/dts/omap3-n950.dts index 0885b34d5d7d..41b8fb585272 100644
> --- a/arch/arm/boot/dts/omap3-n950.dts
> +++ b/arch/arm/boot/dts/omap3-n950.dts
> @@ -17,6 +17,26 @@
> compatible = "nokia,omap3-n950", "ti,omap36xx", "ti,omap3";
> };
>
> +&omap3_pmx_core {
> + dsi_pins: pinmux_dsi_pins {
> + pinctrl-single,pins = <
> + OMAP3_CORE1_IOPAD(0x20dc, PIN_OUTPUT | MUX_MODE1) /* dsi_dx0 -
> data0+ */
> + OMAP3_CORE1_IOPAD(0x20de, PIN_OUTPUT | MUX_MODE1) /* dsi_dy0 -
> data0- */
> + OMAP3_CORE1_IOPAD(0x20e0, PIN_OUTPUT | MUX_MODE1) /* dsi_dx1 -
> clk+ */
> + OMAP3_CORE1_IOPAD(0x20e2, PIN_OUTPUT | MUX_MODE1) /* dsi_dy1 -
> clk- */
> + OMAP3_CORE1_IOPAD(0x20e4, PIN_OUTPUT | MUX_MODE1) /* dsi_dx2 -
> data1+ */
> + OMAP3_CORE1_IOPAD(0x20e6, PIN_OUTPUT | MUX_MODE1) /* dsi_dy2 -
> data1- */
> + >;
> + };
> +
> + display_pins: pinmux_display_pins {
> + pinctrl-single,pins = <
> + OMAP3_CORE1_IOPAD(0x20ca, PIN_INPUT | MUX_MODE4) /* gpio 62 -
> display te */
> + OMAP3_CORE1_IOPAD(0x20fe, PIN_OUTPUT | MUX_MODE4) /* gpio 87 -
> display reset */
> + >;
> + };
> +};
> +
> &i2c2 {
> smia_1: camera@10 {
> compatible = "nokia,smia";
> @@ -53,3 +73,54 @@
> };
> };
> };
> +
> +&dss {
> + status = "ok";
> +
> + vdda_video-supply = <&vdac>;
> +};
> +
> +&dsi {
> + status = "ok";
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&dsi_pins>;
> +
> + vdd-supply = <&vpll2>;
> +
> + port {
> + dsi_out_ep: endpoint {
> + remote-endpoint = <&lcd0_in>;
> + lanes = <2 3 0 1 4 5>;
> + };
> + };
> +
> + lcd0: display {
> + compatible = "nokia,himalaya", "panel-dsi-cm";
> + label = "lcd0";
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&display_pins>;
> +
> + vpnl-supply = <&vmmc2>;
> + vddi-supply = <&vio>;
> +
> + reset-gpios = <&gpio3 23 GPIO_ACTIVE_HIGH>; /* 87 */
> + te-gpios = <&gpio2 30 GPIO_ACTIVE_HIGH>; /* 62 */
> +
> + has-dsi-backlight;
> +
> + /* panel is 480x464 with top and bottom 5 lines not visible */

I assume you mean 480x864 ?

> + /* physical dimensions: 48960µm x 88128µm */
> + resolution-x = <480>;
> + resolution-y = <854>;
> + offset-x = <0>;
> + offset-y = <5>;
> +
> + port {
> + lcd0_in: endpoint {
> + remote-endpoint = <&dsi_out_ep>;
> + };
> + };
> + };
> +};

--
Regards,

Laurent Pinchart