From: Jacob Pan <jacob.jun.pan@linux.intel.com>
To: Peter Zijlstra <peterz@infradead.org>,
LKML <linux-kernel@vger.kernel.org>
Cc: Rafael Wysocki <rafael.j.wysocki@intel.com>,
Len Brown <len.brown@intel.com>,
Andi Kleen <andi.kleen@intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Paul Turner <pjt@google.com>,
Tim Chen <tim.c.chen@linux.intel.com>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Eduardo Valentin <edubezval@gmail.com>,
Punit Agrawal <punit.agrawal@arm.com>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
Jacob Pan <jacob.jun.pan@linux.intel.com>
Subject: [RFC PATCH v2 2/3] timer: relax tick stop in idle entry
Date: Mon, 9 Nov 2015 16:21:22 -0800 [thread overview]
Message-ID: <1447114883-23851-3-git-send-email-jacob.jun.pan@linux.intel.com> (raw)
In-Reply-To: <1447114883-23851-1-git-send-email-jacob.jun.pan@linux.intel.com>
Upon entering idle, we can turn off tick if the next timeout
is exactly one tick away. Otherwise, we could enter inner idle loop
with tick still enabled, without resched set, the tick will continue
during idle therefore less optimal in terms of energy savings.
Signed-off-by: Jacob Pan <jacob.jun.pan@linux.intel.com>
---
kernel/time/tick-sched.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c
index 7c7ec45..bcadaab 100644
--- a/kernel/time/tick-sched.c
+++ b/kernel/time/tick-sched.c
@@ -606,7 +606,7 @@ static ktime_t tick_nohz_stop_sched_tick(struct tick_sched *ts,
* restart it proper.
*/
delta = next_tick - basemono;
- if (delta <= (u64)TICK_NSEC) {
+ if (delta < (u64)TICK_NSEC) {
tick.tv64 = 0;
if (!ts->tick_stopped)
goto out;
--
1.9.1
next prev parent reply other threads:[~2015-11-10 0:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-10 0:21 [RFC PATCH v2 0/3] CFS idle injection Jacob Pan
2015-11-10 0:21 ` [RFC PATCH v2 1/3] ktime: add a roundup function Jacob Pan
2015-11-10 0:21 ` Jacob Pan [this message]
2015-11-10 0:21 ` [RFC PATCH v2 3/3] sched: introduce synchronized idle injection Jacob Pan
2015-11-10 13:23 ` Peter Zijlstra
2015-11-10 14:01 ` Jacob Pan
2015-11-10 14:58 ` Peter Zijlstra
2015-11-10 16:28 ` Jacob Pan
2015-11-10 16:36 ` Peter Zijlstra
2015-11-10 16:50 ` Jacob Pan
2015-11-10 17:00 ` Peter Zijlstra
2015-11-10 17:14 ` Jacob Pan
2015-11-10 18:41 ` Jacob Pan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1447114883-23851-3-git-send-email-jacob.jun.pan@linux.intel.com \
--to=jacob.jun.pan@linux.intel.com \
--cc=andi.kleen@intel.com \
--cc=dietmar.eggemann@arm.com \
--cc=edubezval@gmail.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=punit.agrawal@arm.com \
--cc=rafael.j.wysocki@intel.com \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=tglx@linutronix.de \
--cc=tim.c.chen@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox