From: Joe Perches <joe@perches.com>
To: Kees Cook <keescook@chromium.org>, Christoph Hellwig <hch@infradead.org>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
kernel-janitors@vger.kernel.org,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
linux-geode@lists.infradead.org, linux-fbdev@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] video: constify geode ops structures
Date: Tue, 10 Nov 2015 12:49:29 -0800 [thread overview]
Message-ID: <1447188569.2701.91.camel@perches.com> (raw)
In-Reply-To: <CAGXu5j+59jPqd5QWq38KH--i=gBzq2d5j_Z0c2ygG=pfr2+tzw@mail.gmail.com>
On Tue, 2015-11-10 at 12:34 -0800, Kees Cook wrote:
> We can't make everything work just by static
> analyzers and checkpatch.pl runs (meaning the "backstop" comment
> above).
>
> Additionally, having the plugin infrastructure gets us the ability to
> do things that aren't presently possible (see the thread on the
> initify plugin, which can't be done in source alone).
#define __do_const __attribute__((do_const))
...
#ifndef __do_const
#define __do_const
#endif
I think it's always better for the reader to know that a
const struct declaration is used over a non-const struct
when the compiler, via plug-in extension, could convert
the declaration to const.
Is there a warning/info message produced by gcc and the
plug-in when a non-const declaration is converted to
const because of this attribute?
next prev parent reply other threads:[~2015-11-10 20:49 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-08 21:34 [PATCH] video: constify geode ops structures Julia Lawall
2015-11-08 22:16 ` Dan Carpenter
2015-11-08 22:24 ` Julia Lawall
2015-11-09 5:42 ` Dan Carpenter
2015-11-09 6:09 ` Joe Perches
2015-11-09 6:39 ` Julia Lawall
2015-11-09 13:30 ` [kernel-hardening] " Dan Carpenter
2015-11-09 18:12 ` Julia Lawall
2015-11-09 18:19 ` Joe Perches
2015-11-09 13:49 ` Dan Carpenter
2015-11-09 14:50 ` Julia Lawall
2015-11-09 16:39 ` Dan Carpenter
2015-11-09 17:05 ` Emese Revfy
2015-11-09 17:48 ` Julia Lawall
2015-11-09 21:24 ` Kees Cook
2015-11-09 21:55 ` Julia Lawall
2015-11-09 23:34 ` Kees Cook
2015-11-10 1:24 ` PaX Team
2015-11-10 15:44 ` Julia Lawall
2015-11-09 21:20 ` Kees Cook
2015-11-10 6:38 ` Christoph Hellwig
2015-11-10 20:34 ` Kees Cook
2015-11-10 20:49 ` Joe Perches [this message]
2015-11-10 22:02 ` Dan Carpenter
2015-11-10 22:17 ` Joe Perches
2015-11-10 22:34 ` Dan Carpenter
2015-11-10 22:39 ` Joe Perches
2015-11-24 11:28 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1447188569.2701.91.camel@perches.com \
--to=joe@perches.com \
--cc=Julia.Lawall@lip6.fr \
--cc=dan.carpenter@oracle.com \
--cc=hch@infradead.org \
--cc=keescook@chromium.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-geode@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=plagnioj@jcrosoft.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox