Re: [PATCH] Sound: Usb: Misc: ua101: replace le16_to_cpu() with usb_endpoint_maxp()

Clemens Ladisch
2015-11-15T13:55:32Z

Cheah Kok Cheong wrote:
> Commit 939f325f4a0f ("usb: add usb_endpoint_maxp() macro")
>
> And commit 29cc88979a88 ("USB: use usb_endpoint_maxp()
> instead of le16_to_cpu()")

These sentences no verb.

> Patched against
> git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git

This does not belong into the commit message.

> Signed-off-by: Cheah Kok Cheong <thrust73@gmail.com>

Otherwise:
Acked-by: Clemens Ladisch <clemens@ladisch.de>

> ---
> sound/usb/misc/ua101.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/sound/usb/misc/ua101.c b/sound/usb/misc/ua101.c
> index 9581089..c19a5dd 100644
> --- a/sound/usb/misc/ua101.c
> +++ b/sound/usb/misc/ua101.c
> @@ -1037,7 +1037,7 @@ static int detect_usb_format(struct ua101 *ua)
> return -ENXIO;
> }
> ua->capture.usb_pipe = usb_rcvisocpipe(ua->dev, usb_endpoint_num(epd));
> - ua->capture.max_packet_bytes = le16_to_cpu(epd->wMaxPacketSize);
> + ua->capture.max_packet_bytes = usb_endpoint_maxp(epd);
>
> epd = &ua->intf[INTF_PLAYBACK]->altsetting[1].endpoint[0].desc;
> if (!usb_endpoint_is_isoc_out(epd)) {
> @@ -1045,7 +1045,7 @@ static int detect_usb_format(struct ua101 *ua)
> return -ENXIO;
> }
> ua->playback.usb_pipe = usb_sndisocpipe(ua->dev, usb_endpoint_num(epd));
> - ua->playback.max_packet_bytes = le16_to_cpu(epd->wMaxPacketSize);
> + ua->playback.max_packet_bytes = usb_endpoint_maxp(epd);
> return 0;
> }