public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Lu Baolu <baolu.lu@linux.intel.com>
To: Mathias Nyman <mathias.nyman@intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org, x86@kernel.org,
	linux-kernel@vger.kernel.org, Lu Baolu <baolu.lu@linux.intel.com>
Subject: [PATCH v4 07/12] usb: xhci: dbc: handle dbc-configured exit
Date: Tue, 17 Nov 2015 14:38:53 +0800	[thread overview]
Message-ID: <1447742338-8381-8-git-send-email-baolu.lu@linux.intel.com> (raw)
In-Reply-To: <1447742338-8381-1-git-send-email-baolu.lu@linux.intel.com>

DbC might exit configured state in some cases (refer to 7.6.4.4 in
xHCI spec 1.1). Software needs detect and clear this situation by
clearing DCCTRL.DCR and wait until the DbC configured before read
or write oprations.

Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
---
 drivers/usb/early/xhci-dbc.c | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/drivers/usb/early/xhci-dbc.c b/drivers/usb/early/xhci-dbc.c
index f51daa4..8a5a51f 100644
--- a/drivers/usb/early/xhci-dbc.c
+++ b/drivers/usb/early/xhci-dbc.c
@@ -1153,6 +1153,29 @@ static int xdbc_wait_until_bulk_done(struct xdbc_trb *trb, int loops)
 	return -EIO;
 }
 
+static int xdbc_wait_until_dbc_configured(void)
+{
+	int timeout = 0;
+	u32 reg;
+
+	/* Port exits configured state */
+	reg = readl(&xdbcp->xdbc_reg->control);
+	if (!(reg & CTRL_DRC))
+		return 0;
+
+	/* clear run change bit (RW1C) */
+	writel(reg | CTRL_DRC, &xdbcp->xdbc_reg->control);
+
+	do {
+		if (readl(&xdbcp->xdbc_reg->control) & CTRL_DCR)
+			return 0;
+
+		xdbc_udelay(10);
+	} while (timeout++ < XDBC_LOOPS);
+
+	return -ETIMEDOUT;
+}
+
 static int xdbc_bulk_transfer(void *data, int size, int loops, bool read)
 {
 	u64 addr;
@@ -1167,6 +1190,11 @@ static int xdbc_bulk_transfer(void *data, int size, int loops, bool read)
 		return -EINVAL;
 	}
 
+	if (xdbc_wait_until_dbc_configured()) {
+		xdbc_trace("%s: hardware not ready\n", __func__);
+		return -EPERM;
+	}
+
 	ring = (read ? &xdbcp->in_ring : &xdbcp->out_ring);
 	trb = ring->enqueue;
 	cycle = ring->cycle_state;
-- 
2.1.4


  parent reply	other threads:[~2015-11-17  6:42 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-17  6:38 [PATCH v4 00/12] usb: early: add support for early printk through USB3 debug port Lu Baolu
2015-11-17  6:38 ` [PATCH v4 01/12] usb: xhci: add sysfs file for xHCI " Lu Baolu
2015-11-20 14:33   ` Mathias Nyman
2015-11-22  3:02     ` Lu Baolu
2015-11-17  6:38 ` [PATCH v4 02/12] x86: fixmap: add permanent fixmap for xhci " Lu Baolu
2015-11-17  6:38 ` [PATCH v4 03/12] usb: xhci: dbc: probe and setup xhci debug capability Lu Baolu
2015-11-17  6:38 ` [PATCH v4 04/12] usb: xhci: dbc: add support for Intel xHCI dbc quirk Lu Baolu
2015-11-17  6:38 ` [PATCH v4 05/12] usb: xhci: dbc: add debug buffer Lu Baolu
2015-11-17  6:38 ` [PATCH v4 06/12] usb: xhci: dbc: add bulk out and bulk in interfaces Lu Baolu
2015-11-17  6:38 ` Lu Baolu [this message]
2015-11-17  6:38 ` [PATCH v4 08/12] usb: xhci: dbc: handle endpoint stall Lu Baolu
2015-11-17  6:38 ` [PATCH v4 09/12] x86: early_printk: add USB3 debug port earlyprintk support Lu Baolu
2015-11-17  6:38 ` [PATCH v4 10/12] usb: xhci: dbc: add handshake between debug target and host Lu Baolu
2015-11-17  6:38 ` [PATCH v4 11/12] usb: serial: usb_debug: add support for dbc debug device Lu Baolu
2015-11-17  6:38 ` [PATCH v4 12/12] usb: doc: add document for xHCI DbC driver Lu Baolu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1447742338-8381-8-git-send-email-baolu.lu@linux.intel.com \
    --to=baolu.lu@linux.intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mathias.nyman@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox